-
Notifications
You must be signed in to change notification settings - Fork 144
Move cifmw_installyamls_repos var to group_vars #3430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move cifmw_installyamls_repos var to group_vars #3430
Conversation
|
Skipping CI for Draft Pull Request. |
704d7e8 to
64648b0
Compare
|
recheck |
64648b0 to
be3fd92
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/446a96d2eaf740fb97bf35fb07ebb40e ❌ openstack-k8s-operators-content-provider FAILURE in 5m 17s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/59f5ac5e698c402a8690016fa6a7d406 ❌ openstack-k8s-operators-content-provider FAILURE in 5m 15s |
This commit is one of the steps of replacing common used vars with group_vars to improve overall maintenance of variables in ci-framework Signed-off-by: Amartya Sinha <amsinha@redhat.com>
be3fd92 to
b35c719
Compare
sdatko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sdatko The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
holser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f66a47b
into
openstack-k8s-operators:main
After openstack-k8s-operators/ci-framework#3430 we need to explicitely set the variable. In the edpm jobs we are inheriting it from base definitions, but for kuttl one we need to add it. Signed-off-by: Alfredo Moralejo <amoralej@redhat.com>
|
This seems to have broken some Zuul jobs in a few repos. So far Nova and Watcher have been affected, but there may be more. |
After openstack-k8s-operators/ci-framework#3430 we need to explicitely set the variable. Currently the job is failing with: ''cifmw_installyamls_repos'' is undefined' Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
After openstack-k8s-operators/ci-framework#3430 we need to explicitly set the variable. Currently the job is failing with: ''cifmw_installyamls_repos'' is undefined' Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
After openstack-k8s-operators/ci-framework#3430 we need to explicitely set the variable. In the edpm jobs we are inheriting it from base definitions, but for kuttl one we need to add it. Signed-off-by: Alfredo Moralejo <amoralej@redhat.com>
After openstack-k8s-operators/ci-framework#3430 we need to explicitely set the variable. In the edpm jobs we are inheriting it from base definitions, but for kuttl one we need to add it. Signed-off-by: Alfredo Moralejo <amoralej@redhat.com>
|
Let's try to fix in #3438 |
After openstack-k8s-operators/ci-framework#3430 we need to explicitely set the variable. In the edpm jobs we are inheriting it from base definitions, but for kuttl one we need to add it. Signed-off-by: Alfredo Moralejo <amoralej@redhat.com>
This commit is one of the steps of replacing common used vars with group_vars to improve overall maintenance of variables in ci-framework