-
Notifications
You must be signed in to change notification settings - Fork 144
Adds GH action to sync branches #2797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds GH action to sync branches #2797
Conversation
16ca4d1 to
f25fe47
Compare
f25fe47 to
d921848
Compare
d921848 to
bf25856
Compare
bf25856 to
54ab32f
Compare
|
/hold You can remove the hold when ready to test @frenzyfriday |
54ab32f to
7a9b6ac
Compare
7a9b6ac to
b0e2587
Compare
|
recheck |
jguiditta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I thought I only had the one comment, but keep finding more things to mention as I read though the checkout action docs. I have batched up what I think should be the rest of my thoughts here.
One general suggestion I have is to create your follower branch on your fork to fully test this patch. Then you should be able to see it run in your own fork of the action. I have done this successfully in the past on other projects.
|
Moving to DNM once more. I tested on a dummy repo: https://github.com/frenzyfriday/frenzyfriday-testproject/blob/stable/.github/workflows/sync_branches_reusable_workflow.yml this worked finally. I found an obvious flaw in my patch - it assumes a /sync-olive comment will trigger it. Where will one comment this? On a random PR? No. So I need to find a better trigger for my workflow. So, DNM till I do all that. |
b0e2587 to
f80ad9d
Compare
f80ad9d to
e2a6cce
Compare
Updated some bits. At least the cron sync for olive should work now (while I focus on service users etc) |
|
Team email would just look better ;) |
This is the email id of the github actions bot. I am not sure if I can change it to something specific |
e2a6cce to
e20c7fa
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ac52dce
into
openstack-k8s-operators:main
This PR is to test the following, but on a dummy branch