Skip to content

Conversation

@frenzyfriday
Copy link
Contributor

@frenzyfriday frenzyfriday commented Mar 18, 2025

This PR is to test the following, but on a dummy branch

  • One reusable workflow to actually sync the branches
  • One cron action to call ^ periodically
  • Runs on Monday 21:00 so that I can test if it works

udis
udis previously approved these changes Mar 18, 2025
@frenzyfriday frenzyfriday enabled auto-merge (rebase) March 18, 2025 13:03
bshewale
bshewale previously approved these changes Mar 18, 2025
@lewisdenny
Copy link

/hold

You can remove the hold when ready to test @frenzyfriday

lewisdenny
lewisdenny previously approved these changes Mar 20, 2025
bshewale
bshewale previously approved these changes Mar 20, 2025
lewisdenny
lewisdenny previously approved these changes Mar 20, 2025
@frenzyfriday
Copy link
Contributor Author

recheck

Copy link

@jguiditta jguiditta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I thought I only had the one comment, but keep finding more things to mention as I read though the checkout action docs. I have batched up what I think should be the rest of my thoughts here.
One general suggestion I have is to create your follower branch on your fork to fully test this patch. Then you should be able to see it run in your own fork of the action. I have done this successfully in the past on other projects.

@frenzyfriday
Copy link
Contributor Author

Moving to DNM once more. I tested on a dummy repo: https://github.com/frenzyfriday/frenzyfriday-testproject/blob/stable/.github/workflows/sync_branches_reusable_workflow.yml this worked finally. I found an obvious flaw in my patch - it assumes a /sync-olive comment will trigger it. Where will one comment this? On a random PR? No. So I need to find a better trigger for my workflow.
Also if Require a pull request before merging is enabled the workflow will fail. So I need to create a token with limited permission and allow that token as exception to the PR rule.

So, DNM till I do all that.
We can go with these meanwhile:

@frenzyfriday
Copy link
Contributor Author

Moving to DNM once more. I tested on a dummy repo: https://github.com/frenzyfriday/frenzyfriday-testproject/blob/stable/.github/workflows/sync_branches_reusable_workflow.yml this worked finally. I found an obvious flaw in my patch - it assumes a /sync-olive comment will trigger it. Where will one comment this? On a random PR? No. So I need to find a better trigger for my workflow. Also if Require a pull request before merging is enabled the workflow will fail. So I need to create a token with limited permission and allow that token as exception to the PR rule.

So, DNM till I do all that. We can go with these meanwhile:

Updated some bits. At least the cron sync for olive should work now (while I focus on service users etc)

@danpawlik
Copy link
Contributor

Team email would just look better ;)

@frenzyfriday
Copy link
Contributor Author

Team email would just look better ;)

This is the email id of the github actions bot. I am not sure if I can change it to something specific

@frenzyfriday frenzyfriday force-pushed the gh_action_sync_olive branch from e2a6cce to e20c7fa Compare March 24, 2025 09:46
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@frenzyfriday frenzyfriday merged commit ac52dce into openstack-k8s-operators:main Mar 24, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants