Skip to content

Conversation

@pablintino
Copy link
Contributor

No description provided.

frenzyfriday
frenzyfriday previously approved these changes Feb 4, 2025
Copy link
Contributor

@frenzyfriday frenzyfriday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frenzyfriday frenzyfriday enabled auto-merge (rebase) February 4, 2025 14:28
@bshewale
Copy link
Contributor

bshewale commented Feb 4, 2025

LGTM

@bshewale
Copy link
Contributor

bshewale commented Feb 4, 2025

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bshewale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 4, 2025
evallesp
evallesp previously approved these changes Feb 4, 2025
Copy link
Contributor

@evallesp evallesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pablintino
Copy link
Contributor Author

recheck

@pablintino pablintino dismissed stale reviews from evallesp and frenzyfriday via b95debc February 4, 2025 17:09
@pablintino pablintino force-pushed the remove-ds-trigger-poc branch from f1995e8 to b95debc Compare February 4, 2025 17:09
@pablintino
Copy link
Contributor Author

Copy link

@lewisdenny lewisdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pablintino

@frenzyfriday frenzyfriday merged commit c0cf6f2 into main Feb 5, 2025
5 checks passed
@frenzyfriday frenzyfriday deleted the remove-ds-trigger-poc branch February 5, 2025 00:21
@pablintino
Copy link
Contributor Author

/cherry-pick 18.0-fr1

@openshift-cherrypick-robot

@pablintino: new pull request created: #2713

Details

In response to this:

/cherry-pick 18.0-fr1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

softwarefactory-project-zuul bot added a commit to openstack-k8s-operators/architecture that referenced this pull request Feb 6, 2025
Remove reference to deleted downstream workflow

The workflow referenced no longer exists in CIFMW [1] and throws an error whenever someone comments on a PR.
[1] openstack-k8s-operators/ci-framework#2703

Reviewed-by: John Fulton <johfulto@redhat.com>
tosky added a commit to tosky/osk8sops-architecture that referenced this pull request Sep 5, 2025
The two downstream-* jobs had been removed here:
openstack-k8s-operators/ci-framework#2703

A few references were later removed here:
openstack-k8s-operators#495

But it seems zuul started to complain very recently (today?)
about the missing definitions.
softwarefactory-project-zuul bot added a commit to openstack-k8s-operators/architecture that referenced this pull request Sep 5, 2025
Remove references to downstream-* trigger jobs

The two downstream-* jobs had been removed here:
openstack-k8s-operators/ci-framework#2703
A few references were later removed here:
#495
But it seems zuul started to complain very recently (today?) about the missing definitions.

Reviewed-by: Andrew Bays <andrew.bays@gmail.com>
Reviewed-by: John Fulton <johfulto@redhat.com>
skovili pushed a commit to skovili/architecture that referenced this pull request Oct 13, 2025
The two downstream-* jobs had been removed here:
openstack-k8s-operators/ci-framework#2703

A few references were later removed here:
openstack-k8s-operators#495

But it seems zuul started to complain very recently (today?)
about the missing definitions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants