Skip to content

Conversation

@frenzyfriday
Copy link
Contributor

No description provided.

@github-actions
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@frenzyfriday
Copy link
Contributor Author

The usernames are wrong -I will update them soon

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d3af061a2b314413bf58c6958e495eeb

✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 07s
cifmw-pod-pre-commit FAILURE in 7m 13s
✔️ build-push-container-cifmw-client SUCCESS in 21m 20s

@frenzyfriday frenzyfriday force-pushed the codeowners branch 6 times, most recently from c41d24b to 2a01cda Compare November 26, 2024 11:03
Copy link

@lewisdenny lewisdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @frenzyfriday,

Some extra suggestions:

@vakwetu for roles/compliance
@hjensas for roles/nat64_appliance and roles/libvirt_manager and roles/ssh_jumper and roles/sushy_emulator
@fmount for roles/os_must_gather
@jirimacku for roles/reportportal
@sathlan @Jaganathancse for roles/update

NFV: roles/tofu

@frenzyfriday
Copy link
Contributor Author

Hi @frenzyfriday,

Some extra suggestions:

@vakwetu for roles/compliance @hjensas for roles/nat64_appliance and roles/libvirt_manager and roles/ssh_jumper and roles/sushy_emulator @fmount for roles/os_must_gather @dpinhas for roles/ovirt @kopecmartin for roles/polarion @jirimacku for roles/reportportal @sathlan @Jaganathancse for roles/update

NFV: roles/tofu

Martin is leaving openstack right?

@frenzyfriday frenzyfriday marked this pull request as draft November 26, 2024 15:07
@frenzyfriday frenzyfriday marked this pull request as ready for review November 26, 2024 16:45
@lewisdenny
Copy link

Hi @frenzyfriday,
Some extra suggestions:
@vakwetu for roles/compliance @hjensas for roles/nat64_appliance and roles/libvirt_manager and roles/ssh_jumper and roles/sushy_emulator @fmount for roles/os_must_gather @dpinhas for roles/ovirt @kopecmartin for roles/polarion @jirimacku for roles/reportportal @sathlan @Jaganathancse for roles/update
NFV: roles/tofu

Martin is leaving openstack right?

True, ignore that one, I just parsed the git history and forgot about that move!

Copy link

@lewisdenny lewisdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already approved but the patch additions are nice, thanks for updating to using groups!

@pablintino
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lewisdenny, pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [lewisdenny,pablintino]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pablintino
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 16, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit bc433c8 into openstack-k8s-operators:main Dec 16, 2024
4 checks passed
@frenzyfriday frenzyfriday deleted the codeowners branch January 29, 2025 12:46
@frenzyfriday
Copy link
Contributor Author

/cherry-pick 18.0-fr1

@openshift-cherrypick-robot

@frenzyfriday: new pull request created: #2705

Details

In response to this:

/cherry-pick 18.0-fr1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants