[VA] Deploy a single SSH key for the dataplane

[pablintino]

It seems that the dataplane-operator/baremetal operator is/are having issues building the authorized_keys content of the cloud-init configuration, making BM instances cloud-init to fail when booting.

As a pull request owner and reviewers, I checked that:

• Appropriate testing is done and actually running
• Appropriate documentation exists and/or is up-to-date:
  • README in the role
  • Content of the docs/source is reflecting the changes

[cjeanner]

/approve

Could successfully test it against va-hci env.

This patch here is mostly a workaround before we get openstack-k8s-operators/openstack-baremetal-operator#164 in.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjeanner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [cjeanner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[viroel]

/lgtm

[hjensas]

Did you raise a bug?

Authorized keys in cloud-config should be a list.
https://cloudinit.readthedocs.io/en/latest/reference/modules.html#ssh

AFICT from the code it is setting it as a string.

templateParameters["AuthorizedKeys"] = strings.TrimSuffix(string(sshSecret.Data["authorized_keys"]), "\n")

    ssh-authorized-keys: {{ .AuthorizedKeys }}

https://github.com/openstack-k8s-operators/openstack-baremetal-operator/blob/9a04c56acdf52d1c309b656dfdd4025a95320926/pkg/openstackbaremetalset/baremetalhost.go#L73C3-L73C109
https://github.com/openstack-k8s-operators/openstack-baremetal-operator/blob/9a04c56acdf52d1c309b656dfdd4025a95320926/templates/openstackbaremetalset/cloudinit/userdata#L7