nova04/vfio: fix storage class overriding #661
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdando
force-pushed
the
OSPRH-21650
branch
2 times, most recently
from
93b86f5 to
f08edb1
Compare
bogdando
force-pushed
the
OSPRH-21650
branch
2 times, most recently
from
7bb9dc1 to
06f3b74
Compare
The storage lib component relies on network-values data for setting control plane SC values, historically. The replacement of telemetry data overrides this in the nova04delta and vfio DT/VA. Fixing that by re-applying the storage component logic locally in the DT/VA as well, while repurposing it to control-plane data instead of network-values didn't work in CI (however, it works locally with kustomize build). Fix that by simply providing pvcStorageClass directly in DT/VA. We would not have to fix that, if T-O had been taking the top scope storageClass for its metricStorage template (that fix will be in FR5 likely). Signed-off-by: Bohdan Dobrelia <bdobreli@redhat.com>
bogdando
force-pushed
the
OSPRH-21650
branch
from
06f3b74 to
fed27da
Compare
Contributor
Author
|
it is good to go, downstream testing passed |
hjensas
approved these changes
Nov 28, 2025
danpawlik
approved these changes
Nov 28, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, bogdando, danpawlik, hjensas The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
Build succeeded (gate pipeline). ✔️ noop SUCCESS in 0s |
softwarefactory-project-zuul
bot
merged commit 343cdf7
into
openstack-k8s-operators:main
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The storage lib component relies on network-values data for setting
control plane SC values, historically. The replacement of telemetry
data overrides this in the nova04delta and vfio DT/VA.
Fixing that by re-applying the storage component logic locally in the
DT/VA as well, while repurposing it to control-plane data instead of
network-values didn't work in CI (however, it works locally with
kustomize build).
Fix that by simply providing pvcStorageClass directly in DT/VA.
We would not have to fix that, if T-O had been taking the top scope
storageClass for its metricStorage template (that fix will be in FR5
likely).
Jira: OSPRH-21650