Add BGP adoption job by eduolivares · Pull Request #632 · openstack-k8s-operators/architecture

eduolivares · 2025-10-10T10:15:06Z

Depends-On: openstack-k8s-operators/ci-framework#3397

bgp-l3-xl has been modified to run adoption on it.

OSPRH-20591

Co-authored-by: Luca Miccini lmiccini@redhat.com
Signed-off-by: Eduardo Olivares eolivare@redhat.com

softwarefactory-project-zuul · 2025-10-10T10:29:35Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/728703f46e6a4de1bc1748ec65dd58fd

✔️ noop SUCCESS in 0s
✔️ rhoso-architecture-validate-bgp-l3-xl SUCCESS in 5m 21s
❌ rhoso-architecture-validate-bgp-l3-xl-adoption FAILURE in 4m 06s

eduolivares · 2025-10-10T11:28:46Z

recheck

softwarefactory-project-zuul · 2025-10-10T12:12:24Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/bf8a2f3ea2134e119b1531f262053c6c

✔️ noop SUCCESS in 0s
✔️ rhoso-architecture-validate-bgp-l3-xl SUCCESS in 5m 45s
❌ rhoso-architecture-validate-bgp-l3-xl-adoption FAILURE in 4m 06s

softwarefactory-project-zuul · 2025-11-11T13:09:08Z

This change depends on a change that failed to merge.

Change openstack-k8s-operators/ci-framework#3397 is needed.

softwarefactory-project-zuul · 2025-11-18T15:30:01Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/24f96931050e4700ad88c22f62456eba

✔️ noop SUCCESS in 0s
❌ rhoso-architecture-validate-bgp-l3-xl FAILURE in 4m 15s
❌ rhoso-architecture-validate-bgp-l3-xl-adoption FAILURE in 3m 59s
✔️ rhoso-architecture-validate-nova04delta SUCCESS in 4m 48s
✔️ rhoso-architecture-validate-nova04delta-adoption SUCCESS in 4m 14s
✔️ rhoso-architecture-validate-nvidia-vfio-passthrough SUCCESS in 4m 34s
✔️ rhoso-architecture-validate-nvidia-vfio-passthrough-adoption SUCCESS in 4m 39s

softwarefactory-project-zuul · 2025-12-12T09:22:32Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ec78dfd9a9d14e94a91438fb2451360d

openshift-ci · 2025-12-19T09:10:27Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ccamposr, eduolivares, lmiccini
Once this PR has been reviewed and has the lgtm label, please assign cjeanner for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

bgp-l3-xl has been modified to run adoption on it. Routes to swift resources running on OSP17.1 controller nodes have been added to NNCP and storage NAD. OSPRH-20591 Co-authored-by: Luca Miccini <lmiccini@redhat.com> Signed-off-by: Eduardo Olivares <eolivare@redhat.com>

abays

Just one nit, otherwise /lgtm

Will defer to @fultonj for final approval, as he had some concerns about the commit message.

eduolivares · 2026-01-05T10:52:02Z

@abays @fultonj
thanks for the reviews. I just added the "hold" label because this PR needs to wait for its dependency:
Depends-On: https://github.com/openstack-k8s-operators/ci-framework/pull/3397

fultonj · 2026-01-06T16:04:50Z

Just one nit, otherwise /lgtm

Will defer to @fultonj for final approval, as he had some concerns about the commit message.

I see the commit message was updated (though the not PR message). The commit message makes more sense to me now (why all of these routes are getting added).

    Add BGP adoption job
    
    bgp-l3-xl has been modified to run adoption on it.
    Routes to swift resources running on OSP17.1 controller nodes have been
    added to NNCP and storage NAD.
    
    OSPRH-20591
    
    Co-authored-by: Luca Miccini <lmiccini@redhat.com>
    Signed-off-by: Eduardo Olivares <eolivare@redhat.com>

fultonj · 2026-01-06T15:58:31Z

+  - source:
+      kind: ConfigMap
+      name: network-values
+      fieldPath: data.bgp.prefix-length-worker-9


I see this gets set here so this change shouldn't introduce a problem.

https://github.com/openstack-k8s-operators/architecture/pull/632/changes#diff-f374c3ec72413552397dd6eb7fa3b66a6adb4d0dd53e4c187e603b96e552ee02R700

fultonj

/lgtm

fultonj · 2026-01-06T16:19:08Z

I'm fine with merging this after the following dependency merges:

openstack-k8s-operators/ci-framework#3397

Both this patch and the above ci-framework patch will ultimately be used by the following:

openstack-k8s-operators/data-plane-adoption#1098

eduolivares · 2026-01-14T08:32:06Z

@abays @fultonj
The dependency was merged:
openstack-k8s-operators/ci-framework#3397

openshift-ci Bot requested review from abays and raukadah October 10, 2025 10:15

eduolivares force-pushed the bgp-xl-adoption branch from 2b158a5 to e336cb9 Compare October 10, 2025 10:23

eduolivares marked this pull request as draft October 10, 2025 10:28

openshift-ci Bot added the do-not-merge/work-in-progress label Oct 10, 2025

eduolivares force-pushed the bgp-xl-adoption branch 2 times, most recently from aba84c5 to 07466d9 Compare October 10, 2025 12:41

eduolivares force-pushed the bgp-xl-adoption branch from 07466d9 to dad11be Compare October 24, 2025 09:00

eduolivares force-pushed the bgp-xl-adoption branch from dad11be to 708ff92 Compare November 3, 2025 13:51

eduolivares force-pushed the bgp-xl-adoption branch from 708ff92 to ca30768 Compare November 11, 2025 13:07

eduolivares force-pushed the bgp-xl-adoption branch from ca30768 to 4d9f313 Compare November 18, 2025 15:20

eduolivares force-pushed the bgp-xl-adoption branch 4 times, most recently from 3e24928 to 5f4cc0a Compare November 25, 2025 08:43

eduolivares force-pushed the bgp-xl-adoption branch 2 times, most recently from da4df3b to 74c7b77 Compare December 9, 2025 13:27

eduolivares marked this pull request as ready for review December 9, 2025 13:27

openshift-ci Bot removed the do-not-merge/work-in-progress label Dec 9, 2025

openshift-ci Bot requested review from fultonj and leifmadsen December 9, 2025 13:28

eduolivares changed the title ~~Add bgp-l3-xl-adoption.yaml automation file~~ Add BGP adoption job Dec 9, 2025

eduolivares force-pushed the bgp-xl-adoption branch from 74c7b77 to c1473a5 Compare December 9, 2025 14:18

eduolivares force-pushed the bgp-xl-adoption branch from 218bbaa to 384c9ba Compare December 12, 2025 13:30

eduolivares force-pushed the bgp-xl-adoption branch 3 times, most recently from 54cc130 to 0036bba Compare December 18, 2025 09:36

eduolivares marked this pull request as ready for review December 18, 2025 13:53

openshift-ci Bot removed the do-not-merge/work-in-progress label Dec 18, 2025

openshift-ci Bot requested a review from karelyatin December 18, 2025 13:53

eduolivares added the testing-complete Testing is completed and ready for final reviews label Dec 18, 2025

lmiccini approved these changes Dec 19, 2025

View reviewed changes

openshift-ci Bot assigned lmiccini Dec 19, 2025

openshift-ci Bot added the lgtm label Dec 19, 2025

ccamposr approved these changes Dec 19, 2025

View reviewed changes

openshift-ci Bot assigned ccamposr Dec 19, 2025

eduolivares force-pushed the bgp-xl-adoption branch from 0036bba to 9a43e5f Compare December 24, 2025 08:09

openshift-ci Bot removed the lgtm label Dec 24, 2025

abays reviewed Jan 5, 2026

View reviewed changes

Comment thread automation/mocks/bgp-l3-xl-adoption.yaml

abays reviewed Jan 5, 2026

View reviewed changes

eduolivares added the do-not-merge/hold label Jan 5, 2026

fultonj reviewed Jan 6, 2026

View reviewed changes

openshift-ci Bot assigned fultonj Jan 6, 2026

openshift-ci Bot added the lgtm label Jan 6, 2026

eduolivares removed the do-not-merge/hold label Jan 14, 2026

eduolivares merged commit 0045bc4 into openstack-k8s-operators:main Jan 15, 2026
8 checks passed

eduolivares deleted the bgp-xl-adoption branch January 15, 2026 07:22

Conversation

eduolivares commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

softwarefactory-project-zuul Bot commented Oct 10, 2025

Uh oh!

eduolivares commented Oct 10, 2025

Uh oh!

softwarefactory-project-zuul Bot commented Oct 10, 2025

Uh oh!

softwarefactory-project-zuul Bot commented Nov 11, 2025

Uh oh!

softwarefactory-project-zuul Bot commented Nov 18, 2025

Uh oh!

softwarefactory-project-zuul Bot commented Dec 12, 2025

Uh oh!

openshift-ci Bot commented Dec 19, 2025

Uh oh!

Uh oh!

abays left a comment

Choose a reason for hiding this comment

Uh oh!

eduolivares commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fultonj commented Jan 6, 2026

Uh oh!

Uh oh!

fultonj Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

fultonj left a comment

Choose a reason for hiding this comment

Uh oh!

fultonj commented Jan 6, 2026

Uh oh!

eduolivares commented Jan 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

eduolivares commented Oct 10, 2025 •

edited

Loading

eduolivares commented Jan 5, 2026 •

edited

Loading