feat: add max header as an optional settings#77
feat: add max header as an optional settings#77ImFelipeOliveira wants to merge 2 commits intoopensource-nepal:mainfrom
Conversation
aj3sh
left a comment
There was a problem hiding this comment.
Hey @ImFelipeOliveira, thank you for the contribution! I really appreciate the work you’ve done here. However, a few things are missing, and I’ve pointed them out.
| default: 'false' | ||
| default: "false" | ||
| required: false | ||
| max_header_length: |
There was a problem hiding this comment.
The inputs are not loaded directly to commitlint from github actions. Here are the steps:
-
Add input in the inputs section of
action.yml. (Already done) -
Load it as an env variable, at the end of the file at "Commitlint Action" step.
-
Use the env variable at
github_actions/action/run.pyto add it as an argument. (you can take reference fromINPUT_VERBOSE). -
Load the args to the config on
src/commitlint/cli.py::main(referenceconfig.verbose = args.verbose). Make sure to handle the optional case 🙂. -
Update the
README.mdregarding the GitHub Actions input.
Description
Added configurable maximum header length for commit messages.
Related Issue
[If your pull request is related to an existing issue, reference it here using the format "Fixes #issue_number".]
Type of Change
Please mark the appropriate option below to describe the type of change your pull request introduces:
Checklist
Examples:
"fix: Fixed foobar bug","feat(accounts): Added foobar feature".README.md.Additional Notes
[Add any additional notes or context that you think the reviewers should know about.]
By submitting this pull request, I confirm that I have read and complied with the contribution guidelines of this project.