[WIP] Clean up URL handing in Sippy #3057
Conversation
|
Pipeline controller notification For optional jobs, comment |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
| // triage entries will only be available when there is a postgres connection | ||
| if (localDBEnabled) { | ||
| triageFetch = fetch(getTriagesAPIUrl()).then((response) => { | ||
| triageFetch = apiFetch('/api/component_readiness/triages').then((response) => { |
There was a problem hiding this comment.
@smg247 Do you prefer the approach of using getXXXAPIurl helpers for every endpoint?
|
@stbenjam: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
Adds a centralized
apiFetchhelper to avoid needing concatenation all over the place