[release-4.20] OCPBUGS-79529: Lower verbosity for parseIPList empty list logging by openshift-cherrypick-robot · Pull Request #753 · openshift/router

openshift-cherrypick-robot · 2026-03-25T10:18:45Z

This is an automated cherry-pick of #752

/assign alebedev87

Since it's impossible to distinguish between an unset value and a value set as empty, we prefer to lower the verbosity from V(0) to V(7) to reduce unnecessary logging.

coderabbitai · 2026-03-25T10:19:11Z

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 51138193-46a0-4e06-a305-63df2f9e44b3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci-robot · 2026-03-25T10:20:13Z

@openshift-cherrypick-robot: Jira Issue OCPBUGS-79374 has been cloned as Jira Issue OCPBUGS-79529. Will retitle bug to link to clone.
/retitle [release-4.20] OCPBUGS-79529: Lower verbosity for parseIPList empty list logging

Details

In response to this:

This is an automated cherry-pick of #752

/assign alebedev87

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-03-25T10:20:22Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-79529, which is invalid:

expected dependent Jira Issue OCPBUGS-79374 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #752

/assign alebedev87

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

lihongan · 2026-03-26T12:29:29Z

/jira refresh

openshift-ci-robot · 2026-03-26T12:29:36Z

@lihongan: This pull request references Jira Issue OCPBUGS-79529, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.20.z) matches configured target version for branch (4.20.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-79374 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-79374 targets the "4.21.z" version, which is one of the valid target versions: 4.21.0, 4.21.z
bug has dependents

Requesting review from QA contact:
/cc @ShudiLi

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

lihongan · 2026-03-26T12:30:28Z

/retest-required

alebedev87

/lgtm
/approve

openshift-ci · 2026-03-26T14:11:15Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [alebedev87]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ShudiLi · 2026-03-27T07:15:01Z

tested it with 4.20.0-0-2026-03-27-054602-test-ci-ln-x748q52-latest

1.
% oc get clusterversion
NAME      VERSION                                                AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.20.0-0-2026-03-27-054602-test-ci-ln-x748q52-latest   True        False         34m     Cluster version is 4.20.0-0-2026-03-27-054602-test-ci-ln-x748q52-latest

2. Create a deployment and the service, then created 821 routes by a script
% oc get route | wc -l
     823

3. Check the router log
% oc -n openshift-ingress logs router-default-786f64f79d-292mh                   
I0327 06:20:34.688837       1 template.go:560] "msg"="starting router" "logger"="router" "version"="majorFromGit: \nminorFromGit: \ncommitFromGit: 2720e620f\nversionFromGit: v0.0.0-unknown\ngitTreeState: dirty\nbuildDate: 2026-03-27T05:39:28Z\n"
I0327 06:20:34.690461       1 metrics.go:156] "msg"="router health and metrics port listening on HTTP and HTTPS" "address"="0.0.0.0:1936" "logger"="metrics"
I0327 06:20:34.693771       1 router.go:214] "msg"="creating a new template router" "logger"="template" "writeDir"="/var/lib/haproxy"
I0327 06:20:34.693818       1 router.go:298] "msg"="router will coalesce reloads within an interval of each other" "interval"="5s" "logger"="template"
I0327 06:20:34.694240       1 router.go:368] "msg"="watching for changes" "logger"="template" "path"="/etc/pki/tls/private"
I0327 06:20:34.694304       1 router.go:283] "msg"="router is including routes in all namespaces" "logger"="router"
I0327 06:20:34.701852       1 reflector.go:359] Caches populated for *v1.Route from github.com/openshift/router/pkg/router/controller/factory/factory.go:124
I0327 06:20:34.707791       1 reflector.go:359] Caches populated for *v1.EndpointSlice from github.com/openshift/router/pkg/router/controller/factory/factory.go:124
I0327 06:20:34.708964       1 reflector.go:359] Caches populated for *v1.Service from github.com/openshift/router/pkg/router/template/service_lookup.go:33
E0327 06:20:34.797762       1 haproxy.go:418] can't scrape HAProxy: dial unix /var/lib/haproxy/run/haproxy.sock: connect: no such file or directory
I0327 06:20:34.829547       1 router.go:665] "msg"="router reloaded" "logger"="template" "output"=" - Checking http://localhost:80 using PROXY protocol ...\n - Health check ok : 0 retry attempt(s).\n"
I0327 06:20:39.831497       1 router.go:665] "msg"="router reloaded" "logger"="template" "output"=" - Ch
...
I0327 07:06:40.567351       1 router.go:665] "msg"="router reloaded" "logger"="template" "output"=" - Checking http://localhost:80 using PROXY protocol ...\n - Health check ok : 0 retry attempt(s).\n"
I0327 07:06:45.579004       1 router.go:665] "msg"="router reloaded" "logger"="template" "output"=" - Checking http://localhost:80 using PROXY protocol ...\n - Health check ok : 0 retry attempt(s).\n"
%

4.
% oc get deployment
NAME            READY   UP-TO-DATE   AVAILABLE   AGE
appach-server   2/2     2            2           26m
% oc scale deployment appach-server --replicas=10
deployment.apps/appach-server scaled

5. Checked the router log again, there isn't the parseIPList log
% oc -n openshift-ingress logs router-default-786f64f79d-292mh | grep parseIPList
%

ShudiLi · 2026-03-27T07:15:29Z

/test e2e-agnostic

ShudiLi · 2026-03-27T07:15:54Z

/verified by @ShudiLi

openshift-ci-robot · 2026-03-27T07:16:07Z

@ShudiLi: This PR has been marked as verified by @ShudiLi.

Details

In response to this:

/verified by @ShudiLi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

alebedev87 · 2026-03-27T09:16:00Z

/assign @candita
/assign @Miciah

For backport risk assessment.

openshift-ci · 2026-03-27T10:13:02Z

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

candita · 2026-03-31T16:57:56Z

This backport is a one-line change to reduce logs and imposes no risk.

/label backport-risk-assessed

openshift-ci-robot · 2026-03-31T17:03:22Z

@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-79529
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-79529 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

This is an automated cherry-pick of #752

/assign alebedev87

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-robot · 2026-04-02T16:30:20Z

Fix included in accepted release 4.20.0-0.nightly-2026-04-02-035740

OCPBUGS-72591: Lower verbosity for parseIPList empty list logging

59e3902

Since it's impossible to distinguish between an unset value and a value set as empty, we prefer to lower the verbosity from V(0) to V(7) to reduce unnecessary logging.

openshift-cherrypick-robot assigned alebedev87 Mar 25, 2026

openshift-cherrypick-robot mentioned this pull request Mar 25, 2026

[release-4.21] OCPBUGS-79374: Lower verbosity for parseIPList empty list logging #752

Merged

openshift-ci Bot requested review from Miciah and frobware March 25, 2026 10:19

openshift-ci Bot changed the title ~~[release-4.20] OCPBUGS-79374: Lower verbosity for parseIPList empty list logging~~ [release-4.20] OCPBUGS-79529: Lower verbosity for parseIPList empty list logging Mar 25, 2026

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 25, 2026

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Mar 26, 2026

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 26, 2026

openshift-ci Bot requested a review from ShudiLi March 26, 2026 12:29

alebedev87 approved these changes Mar 26, 2026

View reviewed changes

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 27, 2026

openshift-ci Bot assigned candita and Miciah Mar 27, 2026

openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 31, 2026

openshift-ci Bot assigned lihongan, melvinjoseph86, rhamini3 and ShudiLi Mar 31, 2026

openshift-merge-bot Bot merged commit b4cda19 into openshift:release-4.20 Mar 31, 2026
9 checks passed

Conversation

openshift-cherrypick-robot commented Mar 25, 2026

Uh oh!

coderabbitai Bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

openshift-ci-robot commented Mar 25, 2026

Uh oh!

openshift-ci-robot commented Mar 25, 2026

Uh oh!

lihongan commented Mar 26, 2026

Uh oh!

openshift-ci-robot commented Mar 26, 2026

Uh oh!

lihongan commented Mar 26, 2026

Uh oh!

alebedev87 left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Mar 26, 2026

Uh oh!

ShudiLi commented Mar 27, 2026

Uh oh!

ShudiLi commented Mar 27, 2026

Uh oh!

ShudiLi commented Mar 27, 2026

Uh oh!

openshift-ci-robot commented Mar 27, 2026

Uh oh!

alebedev87 commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Mar 27, 2026

Uh oh!

candita commented Mar 31, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 31, 2026

Uh oh!

openshift-merge-robot commented Apr 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

coderabbitai Bot commented Mar 25, 2026 •

edited

Loading

alebedev87 commented Mar 27, 2026 •

edited

Loading