Skip to content

Add resource limits for CPU and memory#79706

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
deepsm007:patch-43
May 26, 2026
Merged

Add resource limits for CPU and memory#79706
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
deepsm007:patch-43

Conversation

@deepsm007
Copy link
Copy Markdown
Contributor

@deepsm007 deepsm007 commented May 26, 2026

https://redhat-internal.slack.com/archives/CBN38N3MW/p1779799493669429?thread_ts=1779390046.093759&cid=CBN38N3MW
/cc @sosiouxme

Summary by CodeRabbit

This PR adds Kubernetes resource limits for the openshift-eng/ci-test-mapping repository's CI pipeline. The change modifies ci-operator/config/openshift-eng/ci-test-mapping/openshift-eng-ci-test-mapping-main.yaml to define resource limits of 100m CPU and 200Mi memory for all CI tests (via the resources: '*' wildcard). These limits match the existing resource requests, ensuring containers won't exceed these thresholds during CI execution. This aligns with Kubernetes resource management best practices by enforcing hard boundaries on container resource consumption in the CI infrastructure.

@openshift-ci openshift-ci Bot requested a review from sosiouxme May 26, 2026 12:47
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 9c346000-79ae-46c2-8bab-853b8efeb48b

📥 Commits

Reviewing files that changed from the base of the PR and between 09cf84d and 496e280.

📒 Files selected for processing (1)
  • ci-operator/config/openshift-eng/ci-test-mapping/openshift-eng-ci-test-mapping-main.yaml

Walkthrough

This PR adds Kubernetes resource limits to the CI test mapping build root configuration, mirroring the existing requests values (CPU: 100m, memory: 200Mi) to enforce upper bounds on container resource consumption.

Changes

Build Root Resource Limits

Layer / File(s) Summary
Build root resource limits
ci-operator/config/openshift-eng/ci-test-mapping/openshift-eng-ci-test-mapping-main.yaml
Kubernetes resource limits block is added under resources: '*' in the project image configuration, setting CPU and memory limits to 100m and 200Mi respectively to match the existing requests.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Add resource limits for CPU and memory' directly and clearly describes the main change: adding resource limits for CPU and memory to the Kubernetes configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR contains no Ginkgo tests, only YAML configuration changes for Kubernetes resource limits. The custom check for stable test names is not applicable to non-test configuration files.
Test Structure And Quality ✅ Passed The PR modifies configuration YAML files and standard Go tests (using testing.T), not Ginkgo tests. This check requires reviewing Ginkgo test code, so it is not applicable.
Microshift Test Compatibility ✅ Passed PR modifies CI configuration only, adding resource limits to a build config. No Ginkgo e2e tests are added, so MicroShift compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR modifies only CI/CD configuration file, not adding any Ginkgo e2e tests; custom check for SNO test compatibility is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR adds only resource limits/requests to CI config; no topology-breaking scheduling constraints (affinity, topology spread, nodeSelector, etc.) introduced.
Ote Binary Stdout Contract ✅ Passed The check targets OTE binaries communicating via JSON stdout. This PR modifies openshift/release, a CI configuration repo with no OTE binary imports or OTE test extension structures. Not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR adds a YAML configuration file for CI operator resources, not Ginkgo e2e tests. Check only applies when new e2e tests are added.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@deepsm007: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-eng-ci-test-mapping-main-lint openshift-eng/ci-test-mapping presubmit Ci-operator config changed
pull-ci-openshift-eng-ci-test-mapping-main-mapping openshift-eng/ci-test-mapping presubmit Ci-operator config changed
pull-ci-openshift-eng-ci-test-mapping-main-unit openshift-eng/ci-test-mapping presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@sosiouxme
Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 26, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepsm007, sosiouxme

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 26, 2026

@deepsm007: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@deepsm007
Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@deepsm007: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 26, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 9a0b5ca into openshift:main May 26, 2026
14 checks passed
openshift-merge-bot Bot pushed a commit that referenced this pull request May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants