SUSTAINING-2248: cluster-capi-operator release-4.18: increase unit test memory limits#79696
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@rh-soboh: This pull request references SUSTAINING-2248 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughThis PR updates the ci-operator config for cluster-capi-operator release 4.18, adding ChangesCI Resource Configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/ok-to-test |
openshift-ci
Bot
added
the
ok-to-test
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/cluster-capi-operator/openshift-cluster-capi-operator-release-4.18.yaml`:
- Around line 48-53: You modified the CI config resource for the CAPI operator
(the unit: limits/requests block in
openshift-cluster-capi-operator-release-4.18.yaml); run the downstream
regeneration by executing "make update" in the repo, capture and commit any
generated changes, and include the resulting generated diff in the PR (or
explicitly state that running "make update" produced no-op) so reviewers can
verify downstream artifacts were updated.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 3fdbdf01-5cd0-41ee-b3d6-562a3f14f36e
📒 Files selected for processing (1)
ci-operator/config/openshift/cluster-capi-operator/openshift-cluster-capi-operator-release-4.18.yaml
…The grpc-go CVE-2026-33186 bump in PR openshift#566 increased transitive dependency size, causing unit tests to OOMKill (exit 137) under the default 4Gi memory limit with --race and --cover flags. Adds a unit-specific resource override (6Gi limit, 3Gi request, 1 CPU) matching the 4.20/4.21 branch configuration.
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-cluster-capi-operator-release-4.18-unit |
|
@damdo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damdo, rh-soboh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
@rh-soboh: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/pj-rehearse ack |
|
@damdo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
3 participants
Summary
--raceand--coverflags
cc: @damdo
Summary by CodeRabbit
This PR updates the OpenShift CI configuration for the cluster-capi-operator release-4.18 pipeline (ci-operator config: ci-operator/config/openshift/cluster-capi-operator/openshift-cluster-capi-operator-release-4.18.yaml) to raise unit-test resources so tests no longer OOM when run with --race and --cover.
Practical changes:
unitjob:Rationale:
Affected area: