Add Red Hat Hardened Images to mirror#79686
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: feichashao The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
WalkthroughImage mirroring configuration adds supplemental CI image mappings for multiple ChangesSupplemental FIPS image mappings
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@feichashao, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@core-services/image-mirroring/_config.yaml`:
- Around line 242-253: The current mirror mappings for the ci/hi-go entries
(ci/hi-go:1.25-fips-builder, ci/hi-go:1.26-fips-builder, ci/hi-go:1.25-fips,
ci/hi-go:1.26-fips, ci/hi-go:latest-fips, ci/hi-go:latest-fips-builder) point to
registry.access.redhat.com/hi/go which does not resolve; update each mapping to
the actual Hardened Images Docker Hub repository hardened-images/dhi/golang and
use the catalog tag format 1.<go-version>-<distro>-fips-dev (e.g., replace
registry.access.redhat.com/hi/go:1.26-fips with
hardened-images/dhi/golang:1.26-fips-dev), ensuring the tag names exactly match
those shown in the Hardened Images catalog for the corresponding Go versions and
builder/runtime variants.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: a73ed2a1-a488-4230-90a8-07b09f515f8c
📒 Files selected for processing (1)
core-services/image-mirroring/_config.yaml
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@feichashao: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What
This PR adds some Red Hat Hardened images to the mirror.
Why
Red Hat Hardened Images provides the latest Go version, which reduces the CVE to near 0.
We have a repo which would like to keep up with the latest Go version, hence, we will need the CI image to have the latest version in order to perform tests.
Hardened Images: https://images.redhat.com/
Doc about adding mirror: https://docs.ci.openshift.org/how-tos/external-images/
Summary by CodeRabbit