Adding 4.23 nightly jobs for lvms#79680
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (1)
WalkthroughThis PR adds a new OpenShift LVM operator CI configuration file for the 4.23 nightly variant. The configuration establishes the build pipeline, specifies OCP 4.23 base images and release candidates, and registers multiple integration test jobs across AWS and Equinix bare metal infrastructure with varying topologies (single-node and multi-node clusters) and architectures (x86_64 and ARM64). ChangesLVM Operator 4.23 Nightly CI Configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kasturinarra The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/lvm-operator/openshift-lvm-operator-release-4.23__nightly.yaml`:
- Around line 210-237: The job definition for
e2e-baremetalds-mno-dualstack-qe-integration-tests is missing the capabilities
field; add capabilities: [intranet] to that job's top-level spec (peer the SNO
baremetal job) or, if omission is intentional, add a short comment or document
entry explaining why it is excluded; locate the job by the job name
e2e-baremetalds-mno-dualstack-qe-integration-tests and update its YAML to
include the capabilities key/value or an explanatory note.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 46e7fa4b-d456-445e-8801-cc63567301b7
⛔ Files ignored due to path filters (2)
ci-operator/jobs/openshift/lvm-operator/openshift-lvm-operator-release-4.23-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/lvm-operator/openshift-lvm-operator-release-4.23-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (1)
ci-operator/config/openshift/lvm-operator/openshift-lvm-operator-release-4.23__nightly.yaml
|
/pj-rehearse periodic-ci-openshift-lvm-operator-release-4.23-nightly-e2e-aws-sno-qe-integration-tests periodic-ci-openshift-lvm-operator-release-4.23-nightly-e2e-baremetalds-sno-dualstack-qe-integration-tests periodic-ci-openshift-lvm-operator-release-4.23-nightly-e2e-aws-mno-arm-qe-integration-tests periodic-ci-openshift-lvm-operator-release-4.23-nightly-e2e-aws-mno-qe-integration-tests periodic-ci-openshift-lvm-operator-release-4.23-nightly-e2e-aws-sno-arm-qe-integration-tests periodic-ci-openshift-lvm-operator-release-4.23-nightly-e2e-baremetalds-mno-dualstack-qe-integration-tests |
|
@kasturinarra: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@kasturinarra: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The release-4.23 branch does not exist in openshift/lvm-operator since 4.23 and 5.0 both correspond to the main branch. Rename the config from release-4.23__nightly to main__4.23-nightly so jobs clone from main while testing against OCP 4.23 nightly releases. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse periodic-ci-openshift-lvm-operator-main-4.23-nightly-e2e-aws-sno-qe-integration-tests |
|
@kasturinarra: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
1 participant
Summary by CodeRabbit
This PR enables nightly CI testing for the OpenShift LVM operator against OCP 4.23 releases by adding a new Prow job configuration.
What's being changed:
A new CI configuration file (
openshift-lvm-operator-main__4.23-nightly.yaml) is added to define nightly build and test jobs for the LVM operator. The configuration uses themain__4.23-nightlynaming convention to ensure CI clones from the main branch while testing against OCP 4.23 nightly releases.Why this is needed:
The openshift/lvm-operator repository does not have a release-4.23 branch; both 4.23 and 5.0 versions build from the main branch. This configuration enables the proper testing setup for the 4.23 release.
Test coverage:
The configuration defines multiple integration test jobs covering:
All tests use the OCP 4.23 RHEL9 base image and run the LVM operator's integration test suite against the corresponding cluster configurations.