Update Sail Operator jobs to use 4.21 as base and 4.22 as next OCP version#79669
Conversation
Signed-off-by: Francisco Herrera <fjglira@gmail.com>
Signed-off-by: Francisco Herrera <fjglira@gmail.com>
Signed-off-by: Francisco Herrera <fjglira@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughModernize sail-operator CI across main and release branches: bump README channel, convert many release selectors to stable/multi-arch, expand/standardize test suites (unit/integration/gencheck/lint/sync-upstream), add ARM e2e and scorecard jobs, add perfscale installer jobs, and add OCP 4.22 CI configs. ChangesSail Operator CI Configuration Modernization
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci
Bot
added
the
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift-service-mesh/sail-operator/openshift-service-mesh-sail-operator-main__ocp-4.21.yaml`:
- Line 156: SAIL_OPERATOR_CHANNEL is still set to the old 1.29-nightly value;
update the pinned channel to match the new target by changing the
SAIL_OPERATOR_CHANNEL environment variable from "1.29-nightly" to "1.30-nightly"
in the affected manifests (ensure you update both occurrences of
SAIL_OPERATOR_CHANNEL, including the second instance noted around the other
occurrence).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 1a7bc934-22dc-4a34-89d3-021f1ae2cd5c
⛔ Files ignored due to path filters (10)
ci-operator/jobs/openshift-service-mesh/sail-operator/openshift-service-mesh-sail-operator-main-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-service-mesh/sail-operator/openshift-service-mesh-sail-operator-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-service-mesh/sail-operator/openshift-service-mesh-sail-operator-release-3.0-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-service-mesh/sail-operator/openshift-service-mesh-sail-operator-release-3.0-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-service-mesh/sail-operator/openshift-service-mesh-sail-operator-release-3.1-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-service-mesh/sail-operator/openshift-service-mesh-sail-operator-release-3.1-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-service-mesh/sail-operator/openshift-service-mesh-sail-operator-release-3.2-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-service-mesh/sail-operator/openshift-service-mesh-sail-operator-release-3.2-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-service-mesh/sail-operator/openshift-service-mesh-sail-operator-release-3.3-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-service-mesh/sail-operator/openshift-service-mesh-sail-operator-release-3.3-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (16)
ci-operator/config/openshift-service-mesh/sail-operator/README.mdci-operator/config/openshift-service-mesh/sail-operator/openshift-service-mesh-sail-operator-main__ocp-4.20.yamlci-operator/config/openshift-service-mesh/sail-operator/openshift-service-mesh-sail-operator-main__ocp-4.21.yamlci-operator/config/openshift-service-mesh/sail-operator/openshift-service-mesh-sail-operator-main__ocp-4.22.yamlci-operator/config/openshift-service-mesh/sail-operator/openshift-service-mesh-sail-operator-release-3.0__ocp-4.20.yamlci-operator/config/openshift-service-mesh/sail-operator/openshift-service-mesh-sail-operator-release-3.0__ocp-4.21.yamlci-operator/config/openshift-service-mesh/sail-operator/openshift-service-mesh-sail-operator-release-3.0__ocp-4.22.yamlci-operator/config/openshift-service-mesh/sail-operator/openshift-service-mesh-sail-operator-release-3.1__ocp-4.20.yamlci-operator/config/openshift-service-mesh/sail-operator/openshift-service-mesh-sail-operator-release-3.1__ocp-4.21.yamlci-operator/config/openshift-service-mesh/sail-operator/openshift-service-mesh-sail-operator-release-3.1__ocp-4.22.yamlci-operator/config/openshift-service-mesh/sail-operator/openshift-service-mesh-sail-operator-release-3.2__ocp-4.20.yamlci-operator/config/openshift-service-mesh/sail-operator/openshift-service-mesh-sail-operator-release-3.2__ocp-4.21.yamlci-operator/config/openshift-service-mesh/sail-operator/openshift-service-mesh-sail-operator-release-3.2__ocp-4.22.yamlci-operator/config/openshift-service-mesh/sail-operator/openshift-service-mesh-sail-operator-release-3.3__ocp-4.20.yamlci-operator/config/openshift-service-mesh/sail-operator/openshift-service-mesh-sail-operator-release-3.3__ocp-4.21.yamlci-operator/config/openshift-service-mesh/sail-operator/openshift-service-mesh-sail-operator-release-3.3__ocp-4.22.yaml
💤 Files with no reviewable changes (5)
- ci-operator/config/openshift-service-mesh/sail-operator/openshift-service-mesh-sail-operator-main__ocp-4.20.yaml
- ci-operator/config/openshift-service-mesh/sail-operator/openshift-service-mesh-sail-operator-release-3.1__ocp-4.20.yaml
- ci-operator/config/openshift-service-mesh/sail-operator/openshift-service-mesh-sail-operator-release-3.2__ocp-4.20.yaml
- ci-operator/config/openshift-service-mesh/sail-operator/openshift-service-mesh-sail-operator-release-3.3__ocp-4.20.yaml
- ci-operator/config/openshift-service-mesh/sail-operator/openshift-service-mesh-sail-operator-release-3.0__ocp-4.20.yaml
Signed-off-by: Francisco Herrera <fjglira@gmail.com>
|
/pj-rehearse |
|
@fjglira: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-service-mesh-sail-operator-main-ocp-4.22-e2e-ocp |
|
@fjglira: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
The perf test run is expected to fail, it's trying to apply a Istio version that is not yet merged in the midstream repo (because we got failures during the sync PR) |
|
The ARM job failed during the test run with the 137 error, this is expected we are working into solve this issue. Waiting for 4.22 job to finish to merge the PR with the update |
|
/pj-rehearse pull-ci-openshift-service-mesh-sail-operator-main-ocp-4.22-e2e-ocp |
|
@fjglira: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@fjglira, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@fjglira: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Signed-off-by: Francisco Herrera <fjglira@gmail.com>
|
@fjglira, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
4.22 job need this PR to be merged in the midstream repo to pass: istio-ecosystem/sail-operator#1977 |
|
So, all the current failures are related to SYNC failure job and the 137 OOM error. Can we merge this PR @FilipB? The only test that runs on Hypershift passed, idk if is too risky to merge this update, but at the end we are still dealling with the same midstream issues until the 137 exit error is gone |
|
/pj-rehearse ack |
|
@FilipB: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FilipB, fjglira The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
Summary by CodeRabbit
This PR updates OpenShift CI configurations for the Sail Operator repository to advance supported OCP versions: removing OCP 4.20, consolidating 4.21 as the stable base, and adding OCP 4.22 as the new "next" target. The changes affect ci-operator configs and the Sail Operator README.
What changed in practice
#ossm-qe-ci) where applicable.Impact
Estimated review effort: mixed — many deletions of 4.20 files (high for large removals) and medium effort for the expanded 4.21/4.22 job definitions and new perf/scorecard entries.