Skip to content

Fix microshift step registry to not depend on job's build_root#75271

Open
jianzhangbjz wants to merge 1 commit intoopenshift:mainfrom
jianzhangbjz:microshift
Open

Fix microshift step registry to not depend on job's build_root#75271
jianzhangbjz wants to merge 1 commit intoopenshift:mainfrom
jianzhangbjz:microshift

Conversation

@jianzhangbjz
Copy link
Member

To address openshift/operator-framework-olm#1236 (comment)

ERRO[2026-02-25T02:44:13Z] Failed to load arguments.                     error=[tests[e2e-aws-ovn-ocp-conformance].steps.pre[3].from: unknown image "root" (configuration is missing `build_root`), tests[e2e-aws-ovn-ocp-conformance].steps.pre[4].from: unknown image "root" (configuration is missing `build_root`), tests[e2e-aws-ovn-ocp-conformance].steps.pre[5].from: unknown image "root" (configuration is missing `build_root`), tests[e2e-aws-ovn-ocp-conformance].steps.post[1].from: unknown image "root" (configuration is missing `build_root`)]

Summary

  • Replace from: root with from_image in 9 microshift step registry refs to make them portable across different repositories
  • Update ci_get_clonerefs() function to use uname -m instead of go env GOARCH for architecture detection

Problem

Microshift workflows fail when used in Pull Request Payload Qualification (PRPQ) jobs against other repositories (e.g., operator-framework-olm). The error occurs
because:

  ERRO Failed to load arguments. error=[
    tests[e2e-aws-ovn-ocp-conformance].steps.pre[3].from: unknown image "root" (configuration is missing build_root),
    tests[e2e-aws-ovn-ocp-conformance].steps.pre[4].from: unknown image "root" (configuration is missing build_root),
    ...
  ]

Steps using from: root require the job's build_root configuration, which may not exist or be compatible when the workflow is executed in a different repository
context.

Solution

  1. Changed all microshift step refs from from: root to from_image with a fixed image reference (openshift/release:rhel-9-release-golang-1.22-openshift-4.18),
    consistent with the existing openshift-microshift-infra-sos-aws step pattern.

  2. Updated ci_get_clonerefs() to detect architecture using uname -m instead of go env GOARCH, removing the Go dependency for this function.

Assisted-By: Claude-Code

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 25, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jianzhangbjz
Once this PR has been reviewed and has the lgtm label, please assign ggiguash for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 25, 2026

@jianzhangbjz: This PR was included in a payload test run from openshift/operator-framework-olm#1236
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-microshift-release-4.20-periodics-e2e-aws-ovn-ocp-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/41a74be0-122c-11f1-904f-bc0571ce1c16-0

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@jianzhangbjz: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn-microshift openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-5.0-e2e-aws-ovn-microshift openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.23-e2e-aws-ovn-microshift openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.22-e2e-aws-ovn-microshift openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-microshift-main-e2e-aws-footprint-and-performance openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-main-e2e-aws-ai-model-serving openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-5.0-e2e-aws-footprint-and-performance openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-5.0-e2e-aws-ai-model-serving openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.23-e2e-aws-footprint-and-performance openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.23-e2e-aws-ai-model-serving openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.22-e2e-aws-footprint-and-performance openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.22-e2e-aws-ai-model-serving openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.21-e2e-aws-footprint-and-performance openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.21-e2e-aws-ai-model-serving openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.20-e2e-aws-footprint-and-performance openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.20-e2e-aws-ai-model-serving openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.19-e2e-aws-footprint-and-performance openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.19-e2e-aws-ai-model-serving openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.18-e2e-aws-footprint-and-performance openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.17-footprint-and-performance openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.17-e2e-aws-nvidia-device-plugin openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.16-e2e-aws-nvidia-device-plugin openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.14-e2e-aws-nvidia-device-plugin-nightly openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.14-ocp-conformance openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-main-e2e-aws-tests-cache openshift/microshift presubmit Registry content changed

A total of 303 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 25, 2026

@jianzhangbjz: This PR was included in a payload test run from openshift/operator-framework-olm#1236
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-microshift-release-4.20-periodics-e2e-aws-ovn-ocp-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3bdae7b0-1233-11f1-8b95-7266b558161e-0

@jianzhangbjz
Copy link
Member Author

/pj-rehearse pull-ci-openshift-microshift-release-4.23-e2e-aws-footprint-and-performance

@openshift-ci-robot
Copy link
Contributor

@jianzhangbjz: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jianzhangbjz
Copy link
Member Author

/pj-rehearse pull-ci-openshift-microshift-release-4.20-e2e-aws-ai-model-serving

@openshift-ci-robot
Copy link
Contributor

@jianzhangbjz: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 26, 2026

@jianzhangbjz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/microshift/release-4.20/e2e-aws-ai-model-serving e1234ce link unknown /pj-rehearse pull-ci-openshift-microshift-release-4.20-e2e-aws-ai-model-serving

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants