OTA-1813: Allow for alerts to fire from an e2e test#30929
OTA-1813: Allow for alerts to fire from an e2e test#30929openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Walkthrough
Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.11.3)Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions Comment |
hongkailiu
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@hongkailiu: This pull request references OTA-1812 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Sometimes, alerts are triggers to test a feature [1]. We allow for them to fire in CI with a specific prefix on the alert name to avoid overlapping with any alert from production. [1]. https://redhat.atlassian.net/browse/OTA-1813
hongkailiu
force-pushed
the
skip-test-alerts
branch
from
7f51565 to
83ae6e2
Compare
hongkailiu
changed the title
|
@hongkailiu: This pull request references OTA-1813 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@hongkailiu: This pull request references OTA-1813 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Scheduling required tests: |
This is to follow up [1]. We need to fire an alert to test the feature, but it would lead to a job failure unless we get an exception from TRT via [2]. [1]. https://github.com/openshift/cluster-version-operator/pull/1329/changes#r2977643526 [2]. openshift/origin#30929
|
/retest |
This is to follow up [1]. We need to fire an alert to test the feature, but it would lead to a job failure unless we get an exception from TRT via [2]. The local label exclusion in test configuration [3] are left for the "local" cases in the future. [1]. https://github.com/openshift/cluster-version-operator/pull/1329/changes#r2977643526 [2]. openshift/origin#30929 [3]. https://github.com/openshift/cluster-version-operator/blob/bb70c3bf2e0fee968cf02bae00b97b7be837a8b0/cmd/cluster-version-operator-tests/main.go#L23-L38
|
@hongkailiu: This pull request references OTA-1813 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hongkailiu, neisw, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
It adds an exception. The risk is low. /verified by @hongkailiu |
openshift-ci-robot
added
the
verified
|
@hongkailiu: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Scheduling required tests: |
|
@hongkailiu: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
Sometimes, alerts are triggers to test a feature [1]. We allow for them to fire in CI with a specific prefix on the alert name to avoid overlapping with any alert from production.
With the waiving from this pull, we expect to not hit the failure such as this job.
[1]. https://redhat.atlassian.net/browse/OTA-1813