Fix discrepancies in use of failure message vs output#30752
Fix discrepancies in use of failure message vs output#30752dgoodwin wants to merge 1 commit intoopenshift:mainfrom
Conversation
At least two portions of our tooling were ingesting only the output, the message was inconsistently used and never imported in bigquery or sippy. To fix, lets remove the ability to get wires crossed here, from now on we use only the failure output, which is what both databases import.
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgoodwin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test images |
|
/pipeline required |
|
Scheduling required tests: |
|
@dgoodwin: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest |
|
@dgoodwin: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5d476800-01c2-11f1-82a3-8ebb5ff03a46-0 |
|
/payload-aggregate periodic-ci-openshift-release-master-nightly-4.22-e2e-gcp-ovn-rt-rhcos10-techpreview 5 This seems to be working but I saw one case where a test didn't have output but should have: {
"prowjob_build_id": "2019020547676966912",
"prowjob_name": "openshift-origin-30752-ci-4.22-e2e-aws-upgrade-ovn-single-node",
"prowjob_url": "https://prow.ci.openshift.org/view/gs/test-platform-results/logs/openshift-origin-30752-ci-4.22-e2e-aws-upgrade-ovn-single-node/2019020547676966912",
"pr_sha": "6455a00f1d47ef1d0425333d447b3c7c2bc67f86",
"prowjob_start": "2026-02-04T12:09:44Z",
"test_name": "[Monitor:legacy-cvo-invariants][bz-openshift-controller-manager] clusteroperator/openshift-controller-manager should not change condition/Available",
"test_suite": "openshift-tests",
"success": false,
"flaked": false,
"failure_content": ""
},The xml looks the same as other examples that are working fine. |
|
@dgoodwin: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/bd1a51b0-01f5-11f1-82c6-f27a1de16571-0 |
2 participants
At least two portions of our tooling were ingesting only the output, the
message was inconsistently used and never imported in bigquery or sippy.
To fix, lets remove the ability to get wires crossed here, from now on
we use only the failure output, which is what both databases import.
Example from an e2e xml file that imported properly into all dbs:
And the not working xml from a monitortest:
You can see in sippy the test outputs for this test are all empty today
A new sippy API can be used to view all failures from this PR and see how they reported failure content, some of them were monitortests: