TRT-2504,OCPBUGS-74917: Claude command to manage watch request limits, split test by operator/component#30750
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
openshift-ci
Bot
added
the
approved
dgoodwin
changed the title
|
Scheduling required tests: |
| The `update-operator-watch-request-limits` command updates the upper bounds for watch request counts in the test "[sig-arch][Late] operators should not create watch channels very often". This test monitors the number of watch requests created by operators to detect explosive growth in watch channel usage, which can endanger the kube-apiserver and usually indicates a bug. | ||
|
|
||
| The test maintains per-operator, per-platform limits that need periodic adjustments as operators evolve. When the test fails, it typically means watch request counts have gradually increased and need a small bump, provided the increase is not excessive (10x or more) and is explainable. | ||
|
|
There was a problem hiding this comment.
Should we mention the watch-counts dashboard for investigation / verification?
There was a problem hiding this comment.
Added a See Also link at the bottom for the next push.
There was a problem hiding this comment.
Also did some work on the dashboard, it wasn't showing all operators due to a limit 50 on the query for operator names, and I removed network (only one now) arch (should be identical) and fromrelease (we don't alter the limits based on this), so it's a bit less data to process now.
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: fef2718
New tests seen in this PR at sha: fef2718
|
Use P99 not the average, we'll be in trouble too quickly Manual updates for command Remove the update single operator command/
|
Scheduling required tests: |
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: c4c8b9d
New tests seen in this PR at sha: c4c8b9d
|
|
/retest |
|
Scheduling required tests: |
|
/lgtm You are a madman when something gets under your skin... Remarkable. |
|
/retest-required |
|
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: f07857c
|
|
Scheduling required tests: |
|
Open passed tests and you should now see I don't know who is using an SA named 'operator' but that's a problem for another day. Test pass rate resets here, there's nothing to rename going from one test to multiple, but I'd like us to get out of the business of test renames anyhow. All tests will be held to 95% pass rate as new tests, but using a P99 value and only failing if you're more than double it, should mean we do not see this failure at all for some time. |
dgoodwin
changed the title
|
@dgoodwin: This pull request references TRT-2504 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
Actual limit changes are in 433e8a5 |
dgoodwin
changed the title
openshift-ci-robot
added
the
jira/valid-bug
|
@dgoodwin: This pull request references TRT-2504 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. This pull request references Jira Issue OCPBUGS-74917, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (jiazha@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/verified bypass |
openshift-ci-robot
added
the
verified
|
@dgoodwin: The DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: ad7a8a7
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgoodwin, neisw The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@dgoodwin: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@dgoodwin: Jira Issue OCPBUGS-74917: Some pull requests linked via external trackers have merged: The following pull request, linked via external tracker, has not merged:
All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-74917 has not been moved to the MODIFIED state. This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
4 participants
Test will also now inform the user about what the failure means and how to update limits, if it's reasonable to do so.