Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
openshift-ci-robot
added
the
jira/valid-reference
|
@jcmoraisjr: This pull request references NE-906 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Scheduling required tests: |
jcmoraisjr
force-pushed
the
NE-906-fix-dcm-test
branch
from
8a915ec to
eba2f7e
Compare
|
Scheduling required tests: |
|
/retest |
|
Job Failure Risk Analysis for sha: eba2f7e
|
|
/assign @davidesalerno @bentito |
|
/retest |
jcmoraisjr
force-pushed
the
NE-906-fix-dcm-test
branch
from
eba2f7e to
e3f3ab9
Compare
|
@jcmoraisjr: This pull request references NE-906 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Scheduling required tests: |
|
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: e3f3ab9
|
Some fixes to the DCM e2e test. * fix secret name used on the secure endpoint pod * manually update Route resources created via oc expose service, since it seems to be ignoring --labels command-line option. * change router namespace policy to privileged * add IPv6 binding on router and secure-service Jira: https://issues.redhat.com/browse/NE-906
jcmoraisjr
force-pushed
the
NE-906-fix-dcm-test
branch
from
e3f3ab9 to
e85f1ea
Compare
|
@jcmoraisjr: This pull request references NE-906 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Scheduling required tests: |
|
/retest |
|
@jcmoraisjr: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| }) | ||
|
|
||
| oc = exutil.NewCLI("router-config-manager") | ||
| oc = exutil.NewCLIWithPodSecurityLevel("router-config-manager", api.LevelPrivileged) |
There was a problem hiding this comment.
What specific router operations require privileged mode? This should be documented at least in a code comment
There was a problem hiding this comment.
As we talked, #30741 is built on top of this branch, and I'll describe the reason we are using privileged namespace for the router.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: davidesalerno, jcmoraisjr The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
6 participants
Some fixes to the DCM e2e test.
Jira: https://issues.redhat.com/browse/NE-906