-
Notifications
You must be signed in to change notification settings - Fork 4.8k
NO-JIRA: Remove exceptions for NTO #30709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
@jmencak: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cc @hongkailiu |
|
Scheduling required tests: |
|
Thanks, @jmencak There is another place for this bug. $ rg OCPBUGS-62632
pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go
798: return "https://issues.redhat.com/browse/OCPBUGS-62632"
test/extended/machines/scale.go
251: return "https://issues.redhat.com/browse/OCPBUGS-62632"I believe that it is the same cause for the symptom: origin/test/extended/machines/scale.go Line 269 in a325449
The serial test will tell us if removing it is a good idea or not. I am fine if you want to do another pull for that. Otherwise, I made a mistake to reuse OCPBUGS-62632 as the exception here. If you think that is the case, we should create a new one instead. |
NTO should now correctly report ClusterOperator status conditions Available, Progressing and Degraded. See: OCPBUGS-62632
ded286a to
36c734b
Compare
Right, let's try this, removed another occurence. |
|
Scheduling required tests: |
|
The failure in e2e-aws-csi doesn't seem related and the test is not required. |
|
This one from this job still passed. /verified by "CI" |
|
/lgtm |
|
@hongkailiu: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hongkailiu, jmencak The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
I have seen a green run in history. /test e2e-aws-csi |
|
@jmencak: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Thank you @hongkailiu ! |
NTO should now correctly report ClusterOperator status conditions Available, Progressing and Degraded. See: OCPBUGS-62632