NO-ISSUE: Synchronize From Upstream Repositories#1230
NO-ISSUE: Synchronize From Upstream Repositories#1230openshift-bot wants to merge 16 commits intoopenshift:mainfrom
Conversation
|
@openshift-bot: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-bot: GitHub didn't allow me to request PR reviews from the following users: openshift/openshift-team-operator-framework. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retitle OCPBUGS-76460: Synchronize From Upstream Repositories |
|
@openshift-bot: This pull request references Jira Issue OCPBUGS-76460, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Hi @huangmingxia , could you help verify it? Thanks! |
|
This issue still exists in 4.22. Waiting for the PR operator-framework/api#476 to be merged. |
|
@huangmingxia that may not happen for a bit, since it needs to be merged (and it may be replaced by another PR from a different repo) and then incorporated upstream in operator-framework/operator-lifecycle-manager first. In the meantime, can this be verified? |
@tmshort Thanks for the status update. This issue is a blocker bug on the Hive side for OCP 4.22, since the Hive operator could not be successfully deployed.
I created an OCP cluster today using a cluster-bot built image that includes this PR fix, but the issue still reproduces on the Hive side. Please refer to the results above #1230 (comment). Following this, @jianzhangbjz opened the operator-framework/api#476 to address the issue. |
ca5480d to
3e1bdf5
Compare
|
@openshift-bot: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
3e1bdf5 to
7dfe39c
Compare
7dfe39c to
d5b8561
Compare
|
/lgtm |
|
Hi @tmshort @jianzhangbjz I built an image with the current code change and created an OCP cluster. The issue is still reproducible after installing the Hive operator. Could you please help review it when you have time? Thanks. As a comparison, the Hive operator installs successfully on OCP 4.21. |
|
@huangmingxia that requires operator-framework/api#477 to be released upstream (which it has), and then pulled into the upstream operator-lifecycle-manager repo, then it will get pulled down to this repo. In other words, the pieces are slowly falling into place. |
|
@tmshort Thanks for the update. Let me know when it's ready, and I can help run pre-merge tests on Hive side. |
|
Waiting for operator-framework/operator-lifecycle-manager#3777 merging |
|
/retest-required |
|
/retest |
|
/hold |
|
@openshift-bot: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Upstream-repository: operator-lifecycle-manager Upstream-commit: 674bf3f3547e8d8b56c230c5f0df7b5e8be9a3bd
Signed-off-by: grokspawn <jordan@nimblewidget.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: fe30afe2ef3d6b95804c2bdc1cfe0b0006ad1b07
Signed-off-by: Rashmi Gottipati <rgottipa@redhat.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: 0e9d557ec6d9b7ededb96e95cfc11b08ae642cff
Replace hand-written model_name.go with generated zz_generated.model_name.go by adding +k8s:openapi-model-package marker to doc.go and running openapi-gen in update_codegen.sh. Update boilerplate.go.txt to remove Red Hat copyright. Assisted-By: Claude Signed-off-by: Todd Short <todd.short@me.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: 68059b8f2c7bcb60ae54f59d256cb9d61c7d9c8e
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.49.0 to 0.50.0. - [Commits](golang/net@v0.49.0...v0.50.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-version: 0.50.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: 0a96cb289ab11ed8a6cb02e72be3e52974c3a401
Bumps the k8s-dependencies group with 9 updates: | Package | From | To | | --- | --- | --- | | [k8s.io/api](https://github.com/kubernetes/api) | `0.35.0` | `0.35.1` | | [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) | `0.35.0` | `0.35.1` | | [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) | `0.35.0` | `0.35.1` | | [k8s.io/apiserver](https://github.com/kubernetes/apiserver) | `0.35.0` | `0.35.1` | | [k8s.io/client-go](https://github.com/kubernetes/client-go) | `0.35.0` | `0.35.1` | | [k8s.io/code-generator](https://github.com/kubernetes/code-generator) | `0.35.0` | `0.35.1` | | [k8s.io/component-base](https://github.com/kubernetes/component-base) | `0.35.0` | `0.35.1` | | [k8s.io/kube-aggregator](https://github.com/kubernetes/kube-aggregator) | `0.35.0` | `0.35.1` | | [sigs.k8s.io/controller-tools](https://github.com/kubernetes-sigs/controller-tools) | `0.20.0` | `0.20.1` | Updates `k8s.io/api` from 0.35.0 to 0.35.1 - [Commits](kubernetes/api@v0.35.0...v0.35.1) Updates `k8s.io/apiextensions-apiserver` from 0.35.0 to 0.35.1 - [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases) - [Commits](kubernetes/apiextensions-apiserver@v0.35.0...v0.35.1) Updates `k8s.io/apimachinery` from 0.35.0 to 0.35.1 - [Commits](kubernetes/apimachinery@v0.35.0...v0.35.1) Updates `k8s.io/apiserver` from 0.35.0 to 0.35.1 - [Commits](kubernetes/apiserver@v0.35.0...v0.35.1) Updates `k8s.io/client-go` from 0.35.0 to 0.35.1 - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.35.0...v0.35.1) Updates `k8s.io/code-generator` from 0.35.0 to 0.35.1 - [Commits](kubernetes/code-generator@v0.35.0...v0.35.1) Updates `k8s.io/component-base` from 0.35.0 to 0.35.1 - [Commits](kubernetes/component-base@v0.35.0...v0.35.1) Updates `k8s.io/kube-aggregator` from 0.35.0 to 0.35.1 - [Commits](kubernetes/kube-aggregator@v0.35.0...v0.35.1) Updates `sigs.k8s.io/controller-tools` from 0.20.0 to 0.20.1 - [Release notes](https://github.com/kubernetes-sigs/controller-tools/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-tools/blob/main/RELEASE.md) - [Commits](kubernetes-sigs/controller-tools@v0.20.0...v0.20.1) --- updated-dependencies: - dependency-name: k8s.io/api dependency-version: 0.35.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-dependencies - dependency-name: k8s.io/apiextensions-apiserver dependency-version: 0.35.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-dependencies - dependency-name: k8s.io/apimachinery dependency-version: 0.35.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-dependencies - dependency-name: k8s.io/apiserver dependency-version: 0.35.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-dependencies - dependency-name: k8s.io/client-go dependency-version: 0.35.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-dependencies - dependency-name: k8s.io/code-generator dependency-version: 0.35.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-dependencies - dependency-name: k8s.io/component-base dependency-version: 0.35.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-dependencies - dependency-name: k8s.io/kube-aggregator dependency-version: 0.35.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-dependencies - dependency-name: sigs.k8s.io/controller-tools dependency-version: 0.20.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-dependencies ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: 2194d2accd844b1bd53d3ca0dab95ac9bf42d7be
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.78.0 to 1.79.1. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.78.0...v1.79.1) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-version: 1.79.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: c2010bbcac3928ee7c1e8cd3ffeceb9bb3ead0db
…al (#3766) * abandon evaluation of any new catalogsource image which pathologically restrts Signed-off-by: grokspawn <jordan@nimblewidget.com> * add CLBO container considerations to detection Signed-off-by: grokspawn <jordan@nimblewidget.com> --------- Signed-off-by: grokspawn <jordan@nimblewidget.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: feecd01c492f7233c8b215d37b91d69193189bf1
* Add permissions on endpointslice to Prometheus Role * Use serviceDiscoveryRole: EndpointSlice in ServiceMonitors Signed-off-by: Todd Short <todd.short@me.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: 12f8f48cc6ec5c3233cb71d1b026399d087109f7
…om API ports (#3770) * Update NetworkPolicy egress to follow API server best practices Signed-off-by: Rashmi Gottipati <rgottipa@redhat.com> * update NetworkPolicy helpers to use wildcare egress for kube-apiserver Signed-off-by: Rashmi Gottipati <rgottipa@redhat.com> * Add DNS egress rules with ports 53 and 5353 to NetworkPolicies Signed-off-by: Rashmi Gottipati <rgottipa@redhat.com> * add catalog GRPC port rules back Signed-off-by: Rashmi Gottipati <rgottipa@redhat.com> --------- Signed-off-by: Rashmi Gottipati <rgottipa@redhat.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: 6124b659be2880faf63cf1db3d78ec7ae0c7ed80
Co-authored-by: OpenClaw Security <security@openclaw.dev> Upstream-repository: operator-lifecycle-manager Upstream-commit: abb8e1f9536bc067fdff6e2f0e1d13b4d6f7dafe
Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 6 to 7. - [Release notes](https://github.com/goreleaser/goreleaser-action/releases) - [Commits](goreleaser/goreleaser-action@v6...v7) --- updated-dependencies: - dependency-name: goreleaser/goreleaser-action dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: 9fe62d815c547aed09ee2439d2e3132111a6895f
* Update operator-framework/api to v0.40.0 This adds some OpenAPIModelName() functions Signed-off-by: Todd Short <todd.short@me.com> * Update codegen violation exceptions for operator-framework/api v0.40.0 Add new API rule violations to the exceptions list that were introduced by the operator-framework/api v0.40.0 update. Signed-off-by: Jian Zhang <jiazha@redhat.com> --------- Signed-off-by: Todd Short <todd.short@me.com> Signed-off-by: Jian Zhang <jiazha@redhat.com> Co-authored-by: Jian Zhang <jiazha@redhat.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: 521a89f9c683b0dd37e16052b10e57585725a70d
Bumps the k8s-dependencies group with 4 updates: [k8s.io/api](https://github.com/kubernetes/api), [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver), [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) and [k8s.io/client-go](https://github.com/kubernetes/client-go). Updates `k8s.io/api` from 0.35.0 to 0.35.1 - [Commits](kubernetes/api@v0.35.0...v0.35.1) Updates `k8s.io/apiextensions-apiserver` from 0.35.0 to 0.35.1 - [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases) - [Commits](kubernetes/apiextensions-apiserver@v0.35.0...v0.35.1) Updates `k8s.io/apimachinery` from 0.35.0 to 0.35.1 - [Commits](kubernetes/apimachinery@v0.35.0...v0.35.1) Updates `k8s.io/client-go` from 0.35.0 to 0.35.1 - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.35.0...v0.35.1) --- updated-dependencies: - dependency-name: k8s.io/api dependency-version: 0.35.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-dependencies - dependency-name: k8s.io/apiextensions-apiserver dependency-version: 0.35.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-dependencies - dependency-name: k8s.io/apimachinery dependency-version: 0.35.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-dependencies - dependency-name: k8s.io/client-go dependency-version: 0.35.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-dependencies ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Upstream-repository: api Upstream-commit: 1b5c3eaae4931fe77f2933d71ad3d32d9bdedcbb
Signed-off-by: grokspawn <jordan@nimblewidget.com> Upstream-repository: api Upstream-commit: 63554abeb51540fadade28fae27994da20de32f7
…penshift#477) Use openapi-gen from k8s.io/kube-openapi to generate OpenAPIModelName() accessor functions and OpenAPI schema definitions. * Add openapi-gen to bingo. * add +k8s:openapi-gen and +k8s:openapi-model-package markers to pkg/operators/v1alpha1 and pkg/lib/version. * Add a generate-openapi Makefile target. * Remove broken empty +patchMergeKey tag from SubscriptionStatus.CatalogHealth that blocked generation. Assisted-By: Claude Signed-off-by: Todd Short <todd.short@me.com> Upstream-repository: api Upstream-commit: 7641ce3927be5fafc063561ac0c51e570c222c4c
49626b5 to
45dd87d
Compare
|
New changes are detected. LGTM label has been removed. |
The staging/ and vendor/ directories have been synchronized from the upstream repositories, pulling in the following commits:
This pull request is expected to merge without any human intervention. If tests are failing here, changes must land upstream to fix any issues so that future downstreaming efforts succeed.
/cc @openshift/openshift-team-operator-framework