RHDEVDOCS-6360: Reviews for External secrets stores#96694
RHDEVDOCS-6360: Reviews for External secrets stores#96694Dhruv-Soni11 merged 1 commit intoopenshift:pipelines-docs-mainfrom
Conversation
openshift-ci
bot
added
the
size/L
Dhruv-Soni11
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@Dhruv-Soni11: This pull request references RHDEVDOCS-6360 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
🤖 Wed Feb 18 14:44:32 - Prow CI generated the docs preview: |
|
@Dhruv-Soni11: This pull request references RHDEVDOCS-6360 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Dhruv-Soni11
force-pushed
the
RHDEVDOCS-6360
branch
from
17ab670 to
2525092
Compare
waveywaves
left a comment
waveywaves
left a comment
There was a problem hiding this comment.
final few changes, look good other wise
Dhruv-Soni11
force-pushed
the
RHDEVDOCS-6360
branch
from
2525092 to
fa024ca
Compare
aThorp96
left a comment
aThorp96
left a comment
There was a problem hiding this comment.
Looks good to me. One general question for clarification but otherwise fine
waveywaves
left a comment
waveywaves
left a comment
There was a problem hiding this comment.
Tested the configuration here against an openshift cluster. We need these updates on the PR right now.
Dhruv-Soni11
force-pushed
the
RHDEVDOCS-6360
branch
from
fa024ca to
d7b0e0b
Compare
waveywaves
left a comment
waveywaves
left a comment
There was a problem hiding this comment.
It looks good, would be nice to have this note though
Dhruv-Soni11
force-pushed
the
RHDEVDOCS-6360
branch
from
d7b0e0b to
8d0f019
Compare
|
@Dhruv-Soni11: This pull request references RHDEVDOCS-6360 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
ochromy
left a comment
ochromy
left a comment
There was a problem hiding this comment.
Peer review done.
Left a few suggestions.
Otherwise LGTM. Build OK.
Good job, @Dhruv-Soni11!
Dhruv-Soni11
force-pushed
the
RHDEVDOCS-6360
branch
3 times, most recently
from
4315418 to
3f62898
Compare
|
/retest |
Incorporated SME review comments
Dhruv-Soni11
force-pushed
the
RHDEVDOCS-6360
branch
from
3f62898 to
6b756fa
Compare
|
@Dhruv-Soni11: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick pipelines-docs-1.22 |
|
/cherrypick pipelines-docs-1.21 |
|
/cherrypick pipelines-docs-1.20 |
|
/cherrypick pipelines-docs-1.19 |
|
@Dhruv-Soni11: new pull request created: #106892 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@Dhruv-Soni11: new pull request created: #106893 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@Dhruv-Soni11: new pull request created: #106894 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@Dhruv-Soni11: new pull request created: #106895 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
The changes in this PR have been accidentally merged. The reverted PR is as follows: #106976. The final QE and merge review will be performed here. |
9 participants
Version(s):
pipelines-docs-1.19, pipelines-docs-1.20, pipelines-docs-1.21, pipelines-docs-1.22
Issue:
https://issues.redhat.com/browse/RHDEVDOCS-6360
Link to docs preview:
Consuming secrets from an external store such as Hashicorp Vault using the Secrets Store CSI Driver
QE review:
Additional information: