-
Notifications
You must be signed in to change notification settings - Fork 1.9k
OSDOCS-15770#Vol Attribute Classes TP->GA #103425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@lpettyjo: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
dfajmon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes since TP
Parameter Definition and Update Behavior
Customers must verify supported parameters with their storage provider and SHOULD explicitly declare all parameters in every VolumeAttributesClass (VAC) definition.
WARNING
Updating a PVC to use a different VAC functions as a patch operation, not a replacement. If the new VAC does not define a specific parameter that existed in the previous VAC, the PVC retains the old value. To prevent unintended configuration inheritance, ensure the target VAC includes all parameters found in the source VAC.
New Metric: Parameter Mismatch
A new metric, openshift_cluster_storage_vac_mismatch_parameters, helps identify inconsistent parameter sets that could lead to the persistence issues described above.
0: All VACs define the same set of parameters.
1: Mismatch detected. At least one VAC defines a different set of parameters than the others.
Update Frequency & Delays
While users can modify the VAC on a PVC at any time, rapid, successive updates to the same volume may trigger a cooldown period.
If a VAC is changed multiple times in a short duration, the underlying storage provider may enforce a delay. This can result in a wait time of several hours before the most recent VAC change is fully reconciled on the disk.
|
|
||
| The following is an example Volume Attributes Class YAML file for AWS EBS. | ||
|
|
||
| .`VolumeAttributesClass` AWE EBS definition example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| .`VolumeAttributesClass` AWS EBS definition example |
| == Enabling Volume Attributes Classes | ||
| Volume Attributes Classes are not enabled by default. | ||
|
|
||
| To enable Volume Attributes Classes, follow the procedure in section _Enabling {product-title} features using FeatureGates_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove this whole section. Volume Attributes Classes are enabled by default in 4.21
Version(s): 4.21+
Issue: https://issues.redhat.com/browse/OSDOCS-15770
Link to docs preview: https://103425--ocpdocs-pr.netlify.app/openshift-enterprise/latest/storage/understanding-persistent-storage.html#storage-persistent-storage-pvc-volumeattributesclass_understanding-persistent-storage
QE review:
Additional information:
PTAL: @dfajmon @gcharot @radeore