[release-4.18] OCPBUGS-66379: pkg/image: conditionally parse raw image manifest by openshift-cherrypick-robot · Pull Request #585 · openshift/openshift-apiserver

openshift-cherrypick-robot · 2025-12-04T05:31:41Z

This is an automated cherry-pick of #582

/assign ricardomaraschini

the Image REST strategy logs errors when it cannot parse the raw json manifest when creating an Image object. however, this is not an error, as a call to this api might have already cleared the DockerImageManifest from the Image object.

coderabbitai · 2025-12-04T05:31:47Z

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci-robot · 2025-12-04T05:32:00Z

@openshift-cherrypick-robot: Jira Issue OCPBUGS-65962 has been cloned as Jira Issue OCPBUGS-66379. Will retitle bug to link to clone.
/retitle [release-4.18] OCPBUGS-66379: pkg/image: conditionally parse raw image manifest

Details

In response to this:

This is an automated cherry-pick of #582

/assign ricardomaraschini

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-12-04T05:32:09Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-66379, which is invalid:

expected dependent Jira Issue OCPBUGS-65962 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #582

/assign ricardomaraschini

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ricardomaraschini · 2025-12-04T08:51:31Z

/jira refresh

openshift-ci-robot · 2025-12-04T08:51:40Z

@ricardomaraschini: This pull request references Jira Issue OCPBUGS-66379, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.18.z) matches configured target version for branch (4.18.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-65962 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-65962 targets the "4.19.z" version, which is one of the valid target versions: 4.19.0, 4.19.z
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (xiuwang+1@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ricardomaraschini · 2025-12-04T08:52:45Z

/lgtm

ricardomaraschini · 2025-12-04T08:53:10Z

/approve

openshift-ci · 2025-12-04T19:13:09Z

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

flavianmissi · 2025-12-05T16:11:35Z

/approve

openshift-ci · 2025-12-05T16:13:13Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flavianmissi, openshift-cherrypick-robot, ricardomaraschini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~pkg/image/OWNERS~~ [flavianmissi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ShazaAldawamneh · 2026-01-20T09:51:17Z

/cherrypick release-4.17

openshift-cherrypick-robot · 2026-01-20T09:51:21Z

@ShazaAldawamneh: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ingvagabund · 2026-01-20T10:59:10Z

/label backport-risk-assessed

ShazaAldawamneh · 2026-01-20T11:02:09Z

/verified

openshift-ci-robot · 2026-01-20T11:02:13Z

@ShazaAldawamneh: The /verified command must be used with one of the following actions: by, later, remove, or bypass. See https://docs.ci.openshift.org/docs/architecture/jira/#premerge-verification for more information.

Details

In response to this:

/verified

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ShazaAldawamneh · 2026-01-20T11:23:08Z

/verified by @ShazaAldawamneh

openshift-ci-robot · 2026-01-20T11:23:20Z

@ShazaAldawamneh: This PR has been marked as verified by @ShazaAldawamneh.

Details

In response to this:

/verified by @ShazaAldawamneh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-01-20T11:26:04Z

@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-66379
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-66379 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

This is an automated cherry-pick of #582

/assign ricardomaraschini

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-cherrypick-robot · 2026-01-20T11:27:00Z

@ShazaAldawamneh: new pull request created: #596

Details

In response to this:

/cherrypick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-robot · 2026-01-21T02:59:37Z

Fix included in accepted release 4.18.0-0.nightly-2026-01-20-191943

flavianmissi added 2 commits December 4, 2025 05:31

pkg/image: conditionally parse raw image manifest

924192b

the Image REST strategy logs errors when it cannot parse the raw json manifest when creating an Image object. however, this is not an error, as a call to this api might have already cleared the DockerImageManifest from the Image object.

pkg/image: pre-allocate subManifests slice

e58e9a2

openshift-cherrypick-robot assigned ricardomaraschini Dec 4, 2025

openshift-cherrypick-robot mentioned this pull request Dec 4, 2025

[release-4.19] OCPBUGS-65962: pkg/image: conditionally parse raw image manifest #582

Merged

openshift-ci Bot changed the title ~~[release-4.18] OCPBUGS-65962: pkg/image: conditionally parse raw image manifest~~ [release-4.18] OCPBUGS-66379: pkg/image: conditionally parse raw image manifest Dec 4, 2025

openshift-ci Bot requested review from adambkaplan and flavianmissi December 4, 2025 05:32

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 4, 2025

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2025

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2025

openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 20, 2026

openshift-ci Bot assigned gangwgr and wangke19 Jan 20, 2026

openshift-ci Bot assigned xingxingxia Jan 20, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 20, 2026

openshift-merge-bot Bot merged commit ee71d84 into openshift:release-4.18 Jan 20, 2026
11 checks passed

openshift-cherrypick-robot mentioned this pull request Jan 20, 2026

[release-4.17] OCPBUGS-74143: pkg/image: conditionally parse raw image manifest #596

Merged

Conversation

openshift-cherrypick-robot commented Dec 4, 2025

Uh oh!

coderabbitai Bot commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

openshift-ci-robot commented Dec 4, 2025

Uh oh!

openshift-ci-robot commented Dec 4, 2025

Uh oh!

ricardomaraschini commented Dec 4, 2025

Uh oh!

openshift-ci-robot commented Dec 4, 2025

Uh oh!

ricardomaraschini commented Dec 4, 2025

Uh oh!

ricardomaraschini commented Dec 4, 2025

Uh oh!

openshift-ci Bot commented Dec 4, 2025

Uh oh!

flavianmissi commented Dec 5, 2025

Uh oh!

openshift-ci Bot commented Dec 5, 2025

Uh oh!

ShazaAldawamneh commented Jan 20, 2026

Uh oh!

openshift-cherrypick-robot commented Jan 20, 2026

Uh oh!

ingvagabund commented Jan 20, 2026

Uh oh!

ShazaAldawamneh commented Jan 20, 2026

Uh oh!

openshift-ci-robot commented Jan 20, 2026

Uh oh!

ShazaAldawamneh commented Jan 20, 2026

Uh oh!

openshift-ci-robot commented Jan 20, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Jan 20, 2026

Uh oh!

openshift-cherrypick-robot commented Jan 20, 2026

Uh oh!

openshift-merge-robot commented Jan 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

coderabbitai Bot commented Dec 4, 2025 •

edited

Loading