OTA-1856: pkg/cli/admin/release/mirror: Deprecate in favor of oc-mirror by wking · Pull Request #2195 · openshift/oc

wking · 2026-02-05T20:44:28Z

Reduce the number of use-facing commands that need to be documented and maintained. oc-mirror provides a more comprehensive experience, including mirroring OLM catalogs and Sigstore signatures and other functionality that is necessary in most OpenShift deployments.

Summary by CodeRabbit

Deprecations
- The Mirror subcommand in the admin release CLI has been marked as deprecated. This change initiates the deprecation timeline for this functionality.

openshift-ci-robot · 2026-02-05T20:44:32Z

@wking: This pull request references OTA-1856 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Reduce the number of use-facing commands that need to be documented and maintained. oc-mirror provides a more comprehensive experience, including mirroring OLM catalogs and Sigstore signatures and other functionality that is necessary in most OpenShift deployments.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-02-05T20:44:45Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0dca5041-fae0-4ce5-b6d3-108519ce7761

📥 Commits

Reviewing files that changed from the base of the PR and between 84e5849 and 582b29c.

📒 Files selected for processing (1)

pkg/cli/admin/release/mirror.go

🚧 Files skipped from review as they are similar to previous changes (1)

pkg/cli/admin/release/mirror.go

Walkthrough

Added a Deprecated message to the Cobra command for the mirror subcommand indicating deprecation in 4.22 and planned removal in 5.1. No functional changes to Run, Complete, Validate, control flow, or error handling.

Changes

Cohort / File(s)	Summary
Deprecation Notice `pkg/cli/admin/release/mirror.go`	Set the Cobra command's `Deprecated` field to indicate deprecation in 4.22 and planned removal in 5.1; no codepath or behavior changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: deprecating the Mirror command in the admin release subcommand in favor of oc-mirror, directly matching the changeset modifications.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Stable And Deterministic Test Names	✅ Passed	This pull request does not contain any Ginkgo tests. The pkg/cli/admin/release/mirror_test.go file uses the standard Go testing framework with t.Run() subtests, not Ginkgo. All test names are static and descriptive, containing no dynamic information that changes between runs. Since the custom check applies exclusively to Ginkgo test names and this PR contains no Ginkgo tests, the check is not applicable and therefore passes.
Test Structure And Quality	✅ Passed	The custom check requests Ginkgo test code review, but this PR uses Go's standard testing package with table-driven unit tests, not Ginkgo BDD-style tests.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci · 2026-02-05T20:47:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~pkg/cli/admin/release/OWNERS~~ [wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

wking · 2026-02-05T20:48:19Z

Testing with 92e6968:

$ ./oc adm release mirror --help >/dev/null 
Command "mirror" is deprecated, with deprecation (but continued support) in 4.22 with removal planned for 5.0.  Please use oc-mirror instead.

wking · 2026-02-05T20:53:45Z

Subin suggested 5.1 removal instead, so I've pushed 92e6968 -> a577c3a with that pivot.

coderabbitai

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@pkg/cli/admin/release/mirror.go`:
- Around line 96-99: Update the Deprecated message on the mirror command to
match the intended removal version: locate the cobra command definition that has
the Deprecated field (the command with Use: "mirror", Short: "Mirror a release
to a different image registry location") and change the text from "with
deprecation (but continued support) in 4.22 with removal planned for 5.1. 
Please use oc-mirror instead." to use "removal planned for 5.0" so the
deprecation timeline is consistent with the PR and CLI output.

coderabbitai · 2026-02-05T20:56:22Z

pkg/cli/admin/release/mirror.go

 		Use:   "mirror",
 		Short: "Mirror a release to a different image registry location",
+		Deprecated: "with deprecation (but continued support) in 4.22 with removal planned for 5.1.  Please use oc-mirror instead.",
 		Long: templates.LongDesc(`


⚠️ Potential issue | 🟡 Minor

Align deprecation timeline with stated intent (Line 98).

PR objectives and reported CLI output indicate removal planned for 5.0, but the message says 5.1. Please update the version to avoid user-facing inconsistencies.

Proposed fix

- Deprecated: "with deprecation (but continued support) in 4.22 with removal planned for 5.1. Please use oc-mirror instead.", + Deprecated: "with deprecation (but continued support) in 4.22 with removal planned for 5.0. Please use oc-mirror instead.",

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

Use: "mirror",

Short: "Mirror a release to a different image registry location",

Deprecated: "with deprecation (but continued support) in 4.22 with removal planned for 5.1. Please use oc-mirror instead.",

Long: templates.LongDesc(`

Use: "mirror",

Short: "Mirror a release to a different image registry location",

Deprecated: "with deprecation (but continued support) in 4.22 with removal planned for 5.0. Please use oc-mirror instead.",

Long: templates.LongDesc(`

🤖 Prompt for AI Agents

In `@pkg/cli/admin/release/mirror.go` around lines 96 - 99, Update the Deprecated message on the mirror command to match the intended removal version: locate the cobra command definition that has the Deprecated field (the command with Use: "mirror", Short: "Mirror a release to a different image registry location") and change the text from "with deprecation (but continued support) in 4.22 with removal planned for 5.1. Please use oc-mirror instead." to use "removal planned for 5.0" so the deprecation timeline is consistent with the PR and CLI output.

ardaguclu

Considering that oc-mirror covers feature parity of this, I think, this is the right move.

ardaguclu · 2026-02-06T04:32:14Z

pkg/cli/admin/release/mirror.go

-		Short: "Mirror a release to a different image registry location",
+		Use:        "mirror",
+		Short:      "Mirror a release to a different image registry location",
+		Deprecated: "with deprecation (but continued support) in 4.22 with removal planned for 5.1.  Please use oc-mirror instead.",


In order to align with other deprecation messages, what about this;

Suggested change

Deprecated: "with deprecation (but continued support) in 4.22 with removal planned for 5.1. Please use oc-mirror instead.",

Deprecated: "and will be removed in the future (5.1). Use oc-mirror instead.",

dis016 · 2026-02-10T08:08:56Z

Test Scenario: verify warning is present in oc adm release mirror --help

Step1: Launch cluster with changes.

launch 4.22,openshift/oc#2195 aws

Step2: verify warning is present with oc adm release mirror --help

 
dinesh@Dineshs-MacBook-Pro Downloads % ./oc version 
Client Version: v4.2.0-alpha.0-2866-g1d1ef6d
Kustomize Version: v5.7.1
Server Version: 4.22.0-0-2026-02-10-063526-test-ci-ln-xt2fwzb-latest
Kubernetes Version: v1.34.2
dinesh@Dineshs-MacBook-Pro Downloads % ./oc adm release mirror --help >/dev/null
Command "mirror" is deprecated, with deprecation (but continued support) in 4.22 with removal planned for 5.1.  Please use oc-mirror instead.
dinesh@Dineshs-MacBook-Pro Downloads %

dis016 · 2026-02-10T08:09:55Z

/verified by @dis016

dis016 · 2026-03-02T07:45:46Z

/verified by @dis016

openshift-ci-robot · 2026-03-02T07:46:00Z

@dis016: This PR has been marked as verified by @dis016.

Details

In response to this:

/verified by @dis016

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Reduce the number of use-facing commands that need to be documented and maintained. oc-mirror provides a more comprehensive experience, including mirroring OLM catalogs and Sigstore signatures and other functionality that is necessary in most OpenShift deployments.

openshift-ci-robot · 2026-03-06T05:34:52Z

@wking: This pull request references OTA-1856 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Reduce the number of use-facing commands that need to be documented and maintained. oc-mirror provides a more comprehensive experience, including mirroring OLM catalogs and Sigstore signatures and other functionality that is necessary in most OpenShift deployments.

Summary by CodeRabbit

Deprecations

The Mirror subcommand in the admin release CLI has been marked as deprecated. This change initiates the deprecation timeline for this functionality.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ardaguclu · 2026-03-06T05:52:26Z

pkg/cli/admin/release/mirror.go

-		Short: "Mirror a release to a different image registry location",
+		Use:        "mirror",
+		Short:      "Mirror a release to a different image registry location",
+		Deprecated: "with deprecation (but continued support) in 4.22 with removal planned for 6.0.  Please use oc-mirror instead.",


No need to mention about "4.22".

Suggested change

Deprecated: "with deprecation (but continued support) in 4.22 with removal planned for 6.0. Please use oc-mirror instead.",

Deprecated: "and will be removed in the future (6.0). Use oc-mirror instead.",

openshift-ci · 2026-03-06T10:14:06Z

@wking: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 5, 2026

openshift-ci bot requested review from ardaguclu and tchap February 5, 2026 20:47

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2026

wking force-pushed the deprecate-adm-release-mirror branch from b9ef5c0 to 92e6968 Compare February 5, 2026 20:47

wking force-pushed the deprecate-adm-release-mirror branch from 92e6968 to a577c3a Compare February 5, 2026 20:53

coderabbitai bot reviewed Feb 5, 2026

View reviewed changes

wking force-pushed the deprecate-adm-release-mirror branch from a577c3a to 84e5849 Compare February 5, 2026 21:28

ardaguclu reviewed Feb 6, 2026

View reviewed changes

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 2, 2026

wking force-pushed the deprecate-adm-release-mirror branch from 84e5849 to 582b29c Compare March 6, 2026 05:32

openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Mar 6, 2026

ardaguclu reviewed Mar 6, 2026

View reviewed changes

	Deprecated: "with deprecation (but continued support) in 4.22 with removal planned for 5.1. Please use oc-mirror instead.",
	Deprecated: "and will be removed in the future (5.1). Use oc-mirror instead.",

Conversation

wking commented Feb 5, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

openshift-ci-robot commented Feb 5, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

Estimated code review effort

Uh oh!

openshift-ci bot commented Feb 5, 2026

Uh oh!

wking commented Feb 5, 2026

Uh oh!

wking commented Feb 5, 2026

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

ardaguclu left a comment

Choose a reason for hiding this comment

Uh oh!

ardaguclu Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

dis016 commented Feb 10, 2026

Uh oh!

dis016 commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dis016 commented Mar 2, 2026

Uh oh!

openshift-ci-robot commented Mar 2, 2026

Uh oh!

openshift-ci-robot commented Mar 6, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

ardaguclu Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Mar 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

wking commented Feb 5, 2026 •

edited by coderabbitai bot

Loading

openshift-ci-robot commented Feb 5, 2026 •

edited by openshift-ci bot

Loading

coderabbitai bot commented Feb 5, 2026 •

edited

Loading

dis016 commented Feb 10, 2026 •

edited

Loading

openshift-ci-robot commented Mar 6, 2026 •

edited by openshift-ci bot

Loading