RFE-7406: Include the K8s ingress resource in namespace inspect collection#2004
RFE-7406: Include the K8s ingress resource in namespace inspect collection#2004oarribas wants to merge 5 commits intoopenshift:mainfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@oarribas: This pull request references RFE-7406 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature request to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@oarribas: This pull request references RFE-7406 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
1 similar comment
|
/retest |
|
I think, we can't merge anything without having concrete metrics about how the change will impact the logs size and duration -- Especially after trying to fix and lower the logs sizes due to some issues. I'd prefer waiting for the acceptance of the RFE by the workloads team first. |
openshift-ci
bot
added
the
do-not-merge/hold
|
/retest |
|
@ardaguclu bear in mind that this resource is used only in user application namespaces. This means that must-gather should not collect it and should hence not see a difference in size by default. The difference in size would happen only when the customer runs the inspect on their own application namespaces (something we need quite often to provide good support). And in that case:
|
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
it's not clear the test is really failing because the changes in this PR /retest |
|
/retest |
1 similar comment
|
/retest |
|
Checking the failing job [1], I cannot identify where the error with the check is. Not clear if caused by the changes in this PR, or any issue with the check. /retest |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
Changed spaces to tabs |
|
/retest |
|
/retest-required |
3 similar comments
|
/retest-required |
|
/retest-required |
|
/retest-required |
|
/retest |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
@openshift-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/reopen |
|
@palonsoro: Reopened this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@oarribas: This pull request references RFE-7406 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature request to target either version "4.22." or "openshift-4.22.", but it targets "openshift-4.19" instead. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/reopen |
|
@oarribas: This pull request references RFE-7406 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature request to target either version "4.22." or "openshift-4.22.", but it targets "openshift-4.19" instead. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@palonsoro: Reopened this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/hold |
Using group resource type for the K8s ingress Co-authored-by: Arda Güçlü <aguclu@redhat.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@pkg/cli/admin/inspect/namespace.go`:
- Line 35: The composite literal for the resource entry {Group:
"networking.k8s.io", Resource: "ingresses"} is missing a trailing comma which
causes a compile error; update that literal by adding a trailing comma after the
last element so the multi-line composite literal is valid (locate the literal in
pkg/cli/admin/inspect/namespace.go and add the comma to the end of the line
containing Resource: "ingresses").
|
@oarribas: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Currently, trying to use any of the 2 following is not working: Both fails with: If trying wiht only @ardaguclu , should we use |
If this |
|
@ardaguclu , bug OCPBUGS-76958 [1] has been created. |
oarribas
force-pushed
the
gather-k8s-ingress
branch
from
3cad463 to
506edcc
Compare
oarribas
force-pushed
the
gather-k8s-ingress
branch
from
506edcc to
be99ec5
Compare
|
/label tide/merge-method-squash |
openshift-ci
bot
added
tide/merge-method-squash
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
6 participants
Including the K8s
ingress.networking.k8s.ioresource in namespace inspect collections could help to identify if the K8s ingress is in use.It shouldn't increase the size of the inspect or must-gather a lot, as the resource shouldn't be too big.