Skip to content

Conversation

@sebrandon1
Copy link
Member

ioutil has been deprecated since Go 1.16: https://go.dev/doc/go1.16#ioutil

Tracking issue: redhat-best-practices-for-k8s/telco-bot#52

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 24, 2025

Walkthrough

Replaced deprecated ioutil usage with modern os and io APIs: ioutil.ReadFileos.ReadFile, ioutil.ReadAllio.ReadAll. Imports updated; no functional or control-flow changes.

Changes

Cohort / File(s) Summary
ioutil → os/io migration
pkg/leaderelection/leaderelection.go, tests/e2e/lib/common_helpers.go
Replaced ioutil.ReadFile with os.ReadFile and ioutil.ReadAll with io.ReadAll. Updated imports (removed io/ioutil, added os and/or io). No behavioral changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

✨ Finishing touches
  • 📝 Generate docstrings


📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 3874350 and 7ed5cc7.

📒 Files selected for processing (2)
  • pkg/leaderelection/leaderelection.go
  • tests/e2e/lib/common_helpers.go
🚧 Files skipped from review as they are similar to previous changes (1)
  • pkg/leaderelection/leaderelection.go
🧰 Additional context used
📓 Path-based instructions (1)
**

⚙️ CodeRabbit configuration file

-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.

Files:

  • tests/e2e/lib/common_helpers.go
🔇 Additional comments (1)
tests/e2e/lib/common_helpers.go (1)

6-6: LGTM!

Clean migration from the deprecated ioutil package to the modern equivalents (os.ReadFile and io.ReadAll) as recommended since Go 1.16. The changes are correct and preserve existing behavior.

Also applies to: 29-32, 285-285, 294-294

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2025
@weshayutin
Copy link
Contributor

/retest

@openshift-ci
Copy link

openshift-ci bot commented Dec 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, sebrandon1, shubham-pampattiwar, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [kaovilai,shubham-pampattiwar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kaovilai
Copy link
Member

kaovilai commented Dec 5, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2025
@shubham-pampattiwar
Copy link
Member

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f8b06e8 and 2 for PR HEAD 3874350 in total

@kaovilai
Copy link
Member

kaovilai commented Dec 6, 2025

Did we add test cases recently.?

prow/pkg/entrypoint/run.go:169","func":"sigs.k8s.io/prow/pkg/entrypoint.Options.ExecuteProcess","level":"error","msg":"Process did not finish before 2h0m0s timeout","severity":"error","time":"2025-12-06T01:35:01Z"}
{"component":"entrypoint","file":"sigs.k8s.io/prow/pkg/entrypoint/run.go:267

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 7a8aba0 and 1 for PR HEAD 3874350 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f75a38d and 0 for PR HEAD 3874350 in total

@openshift-ci-robot
Copy link

/hold

Revision 3874350 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 15, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2026
@openshift-ci
Copy link

openshift-ci bot commented Jan 16, 2026

New changes are detected. LGTM label has been removed.

@kaovilai
Copy link
Member

/retest

@openshift-ci
Copy link

openshift-ci bot commented Jan 17, 2026

@sebrandon1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.20-e2e-test-cli-aws 3874350 link true /test 4.20-e2e-test-cli-aws
ci/prow/4.21-e2e-test-aws 7ed5cc7 link true /test 4.21-e2e-test-aws
ci/prow/4.21-e2e-test-cli-aws 7ed5cc7 link false /test 4.21-e2e-test-cli-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants