OU-1170: Fix Add Variable - Name with more than 75 chars #727
Conversation
openshift-ci
bot
added
the
approved
zhuje
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@zhuje: This pull request references OU-1170 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
@zhuje: This pull request references OU-1170 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| const { t } = useTranslation(process.env.I18N_NAMESPACE); | ||
|
|
||
| const chartsTheme = useChartsTheme(); | ||
| const { successSnackbar, exceptionSnackbar } = useSnackbar(); |
There was a problem hiding this comment.
Even though Perses currently only supports snackbars for other internal alerts, this will change with the UI customization. We should use the Patternfly alerts: https://www.patternfly.org/components/alert here as we can control them in this component
There was a problem hiding this comment.
Before (Perses SnackBar)
https://github.com/user-attachments/assets/0cd4619e-a6f4-48d3-ae4e-faa5f26813a5
After (Patternfly Alert)
https://github.com/user-attachments/assets/74170e0c-fcc4-4e91-b51c-e77e310836ef
- Description was updated with After video
|
@zhuje: This pull request references OU-1170 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
zhuje
force-pushed
the
ou1170-variable-75char-pr2
branch
from
355033c to
add73fb
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jgbernalp, zhuje The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit d7c885a
into
openshift:customizable-dashboards
4 participants
https://issues.redhat.com/browse/OU-1170
Screen.Recording.2026-01-13.at.12.31.14.PM.mov