-
Notifications
You must be signed in to change notification settings - Fork 39
OCPBUGS-70314: fix: update qs vulnerable dependency #715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-70314: fix: update qs vulnerable dependency #715
Conversation
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
|
@jgbernalp: This pull request references Jira Issue OCPBUGS-70314, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherry-pick release-4.21 |
|
@jgbernalp: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/jira refresh |
|
@jgbernalp: This pull request references Jira Issue OCPBUGS-70314, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
retrying e2e-monitoring due to route failure - infrastructure |
|
/test e2e-monitoring |
|
/override ci/prow/okd-scos-images |
|
@etmurasaki: Overrode contexts on behalf of etmurasaki: ci/prow/okd-scos-images DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jgbernalp, zhuje The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
cc @juzhao |
|
@jgbernalp just a question, I see monitoring-plugin/web/package-lock.json Line 13516 in e7457a8
and monitoring-plugin/web/package-lock.json Line 9974 in e7457a8
should it change to "qs": "~6.14.1",?
also for monitoring-plugin/web/package-lock.json Line 2176 in e7457a8
monitoring-plugin/web/package-lock.json Line 6106 in e7457a8
monitoring-plugin/web/package-lock.json Lines 7906 to 7907 in e7457a8
|
this is fine, some packages that we depend on haven't been patched. But the actual installed version from our side is |
|
/label qe-approved |
|
@jgbernalp: This pull request references Jira Issue OCPBUGS-70314, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/override ci/prow/okd-scos-images |
|
@jgbernalp: Overrode contexts on behalf of jgbernalp: ci/prow/okd-scos-images DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-aws-ovn |
|
@jgbernalp: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@jgbernalp: Jira Issue OCPBUGS-70314: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-70314 has been moved to the MODIFIED state. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@jgbernalp: new pull request created: #718 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
No description provided.