Skip to content

USHIFT-6818: Update optional packages for y2 and y1 releases#6504

Open
pacevedom wants to merge 1 commit intoopenshift:mainfrom
pacevedom:USHIFT-6818
Open

USHIFT-6818: Update optional packages for y2 and y1 releases#6504
pacevedom wants to merge 1 commit intoopenshift:mainfrom
pacevedom:USHIFT-6818

Conversation

@pacevedom
Copy link
Copy Markdown
Contributor

@pacevedom pacevedom commented Apr 15, 2026

Summary by CodeRabbit

Release Notes

This release contains no user-visible changes. Internal test configuration updates were made to optimize package list organization, with no impact on functionality or user experience.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 15, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 15, 2026

@pacevedom: This pull request references USHIFT-6818 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 0443bec8-b8c1-4a0d-8d95-284b72c1d3e8

📥 Commits

Reviewing files that changed from the base of the PR and between 685552c and 0bb11d2.

📒 Files selected for processing (1)
  • test/bin/common.sh

Walkthrough

Two RPM packages (microshift-sriov and microshift-sriov-release-info) are relocated from the Y1 optional RPM list's append section into the Y2 list's base initialization. Y1 now inherits these entries through list expansion, while final exported values remain unchanged.

Changes

Cohort / File(s) Summary
RPM List Reorganization
test/bin/common.sh
Moved microshift-sriov and microshift-sriov-release-info from MICROSHIFT_Y1_OPTIONAL_RPMS_LIST append into base MICROSHIFT_Y2_OPTIONAL_RPMS_LIST initialization. Y1 list now inherits via expansion.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 10
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: moving microshift-sriov packages from Y1 to Y2 optional RPM lists.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed PR modifies test infrastructure shell script without introducing Ginkgo test definitions, so stable test name check is not applicable.
Test Structure And Quality ✅ Passed Custom check not applicable; PR modifies bash script, not Ginkgo test code.
Microshift Test Compatibility ✅ Passed PR modifies test/bin/common.sh RPM package configurations only; no new Ginkgo e2e tests are added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed SNO Test Compatibility check applies only to PRs adding new Ginkgo e2e tests. This PR modifies only test/bin/common.sh (shell script with configuration/setup logic). No Ginkgo test patterns found.
Topology-Aware Scheduling Compatibility ✅ Passed This PR modifies test/bin/common.sh, a test utility script reorganizing optional RPM package names. Since the custom check applies only to deployment manifests, operator code, or controllers, and this is a test utility script containing no scheduling constraints or deployment configurations, the check is not applicable and passes by scope exclusion.
Ote Binary Stdout Contract ✅ Passed The PR modifies test/bin/common.sh, a shell configuration script sourced by test infrastructure. As a utility script rather than an OTE binary, the OTE Binary Stdout Contract is not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR modifies only test/bin/common.sh bash script for RPM package configuration; no new Ginkgo e2e tests added.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from ggiguash and vanhalenar April 15, 2026 08:38
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 15, 2026

@pacevedom: This pull request references USHIFT-6818 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary by CodeRabbit

Release Notes

This release contains no user-visible changes. Internal test configuration updates were made to optimize package list organization, with no impact on functionality or user experience.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@agullon
Copy link
Copy Markdown
Contributor

agullon commented Apr 15, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 15, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agullon, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agullon
Copy link
Copy Markdown
Contributor

agullon commented Apr 15, 2026

/retest

1 similar comment
@pacevedom
Copy link
Copy Markdown
Contributor Author

/retest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 15, 2026

@pacevedom: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants