CORENET-6738: Remove lingering references to openshift-sdn#5591
CORENET-6738: Remove lingering references to openshift-sdn#5591openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@danwinship: This pull request references CORENET-6738 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
danwinship
force-pushed
the
no-openshift-sdn
branch
from
fe63dc6 to
baf5fa3
Compare
|
/retest-required |
|
/assign @umohnani8 |
danwinship
force-pushed
the
no-openshift-sdn
branch
from
baf5fa3 to
cd13fea
Compare
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, ricky-rav, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
approved
|
/verified by CI |
openshift-ci-robot
added
the
verified
|
@danwinship: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
@danwinship: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
5 participants
openshift-sdn was removed in 4.17 so there's no reason to keep code for deploying it around any more.
configure-ovs.sh only gets installed for ovn-k now, so I removed the internal network-type checks. mtu-migration should only get called for ovn-k (based on checks in CNO), but I left the initial check there and just removed the internal ovn-k/openshift-sdn checks.
(some files best viewed with "don't show whitespace changes")