Skip to content

OCPBUGS-54901: Check for API server reachability before updating kubeconfig #10099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sadasu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OCPBUGS-54901: Check for API server reachability before updating kubeconfig #10099

sadasu wants to merge 1 commit into from
+15 −1

Conversation

@sadasu
Copy link
Contributor

@sadasu sadasu commented Nov 17, 2025

Only applicable for custom-dns

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Nov 17, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 17, 2025

@sadasu: This pull request references Jira Issue OCPBUGS-54901, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianli-wei

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Only applicable for custom-dns

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Nov 17, 2025
@openshift-ci openshift-ci bot requested a review from jianli-wei November 17, 2025 23:09
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bfournie for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sadasu sadasu force-pushed the custom-dns-private-installs branch 2 times, most recently from 40a7a2a to a52db9f Compare November 25, 2025 17:20
@sadasu
Copy link
Contributor Author

sadasu commented Nov 26, 2025

/test e2e-gcp-custom-dns

@sadasu sadasu force-pushed the custom-dns-private-installs branch from a52db9f to 15d12bc Compare November 26, 2025 14:47
@sadasu
Copy link
Contributor Author

sadasu commented Nov 26, 2025

/test e2e-gcp-custom-dns

barbacbd
barbacbd reviewed Nov 26, 2025
View reviewed changes
@sadasu sadasu force-pushed the custom-dns-private-installs branch 3 times, most recently from 29c8659 to 7870a9b Compare December 3, 2025 20:06
@sadasu
Copy link
Contributor Author

sadasu commented Dec 3, 2025

/test e2e-gcp-custom-dns

@sadasu sadasu force-pushed the custom-dns-private-installs branch from 7870a9b to 66ed7a0 Compare December 4, 2025 04:58
@sadasu
Copy link
Contributor Author

sadasu commented Dec 4, 2025

/test e2e-gcp-custom-dns

@sadasu sadasu force-pushed the custom-dns-private-installs branch from 66ed7a0 to ef102d4 Compare December 6, 2025 01:15
@sadasu
Copy link
Contributor Author

sadasu commented Dec 6, 2025

/test e2e-gcp-custom-dns

@sadasu sadasu changed the title OCPBUGS-54901: WIP: Check for API server reachability before updating kubeconfig OCPBUGS-54901: Check for API server reachability before updating kubeconfig Dec 8, 2025
@sadasu sadasu force-pushed the custom-dns-private-installs branch from ef102d4 to ed825e8 Compare December 16, 2025 19:14
@sadasu
Copy link
Contributor Author

sadasu commented Dec 16, 2025

/test e2e-gcp-custom-dns

@sadasu sadasu force-pushed the custom-dns-private-installs branch from ed825e8 to 11d25b6 Compare December 18, 2025 07:03
@sadasu
Copy link
Contributor Author

sadasu commented Dec 18, 2025

/test e2e-gcp-custom-dns

@sadasu sadasu force-pushed the custom-dns-private-installs branch from 11d25b6 to e956037 Compare December 18, 2025 07:24
@sadasu
Copy link
Contributor Author

sadasu commented Dec 18, 2025

/test e2e-gcp-custom-dns

@tthvo
Copy link
Member

tthvo commented Dec 19, 2025

/cc

@openshift-ci openshift-ci bot requested a review from tthvo December 19, 2025 00:08
@tthvo
Copy link
Member

tthvo commented Dec 19, 2025

/test e2e-gcp-ovn

1 similar comment
@sadasu
Copy link
Contributor Author

sadasu commented Dec 19, 2025

/test e2e-gcp-ovn

@sadasu sadasu force-pushed the custom-dns-private-installs branch from e956037 to 357d22c Compare January 7, 2026 06:16
@sadasu
Copy link
Contributor Author

sadasu commented Jan 7, 2026

/test e2e-gcp-custom-dns

@sadasu
Copy link
Contributor Author

sadasu commented Jan 7, 2026

/test e2e-gcp-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 7, 2026

@sadasu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-vsphere-ovn ed825e8 link false /test okd-scos-e2e-vsphere-ovn
ci/prow/e2e-gcp-ovn 357d22c link true /test e2e-gcp-ovn
ci/prow/e2e-aws-ovn 357d22c link true /test e2e-aws-ovn
ci/prow/okd-scos-images 357d22c link true /test okd-scos-images
ci/prow/artifacts-images 357d22c link true /test artifacts-images
ci/prow/golint 357d22c link true /test golint
ci/prow/govet 357d22c link true /test govet
ci/prow/e2e-gcp-custom-dns 357d22c link false /test e2e-gcp-custom-dns
ci/prow/images 357d22c link true /test images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sadasu
UserProvisionedDNS on private installs does not need updated kubeconfig
18e4cf3 
When private clusters are installed with userProvisionedDNS enabled, it
is likely that the install host is not in the same network as the
cluster and the LB IP is not reachable from the install host. Using a
kubeconfig with Dialer context does not help with accessing the cluster.

So, continue using the originial kubeconfig with the expectation that
a proxy / bastion host has been setup to access the cluster via its
API server URL.
@sadasu sadasu force-pushed the custom-dns-private-installs branch from 357d22c to 18e4cf3 Compare January 7, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jianli-wei jianli-wei Awaiting requested review from jianli-wei

@pawanpinjarkar pawanpinjarkar Awaiting requested review from pawanpinjarkar

@tthvo tthvo Awaiting requested review from tthvo

1 more reviewer

@barbacbd barbacbd barbacbd left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sadasu @openshift-ci-robot @tthvo @barbacbd