[release-4.21] OCPBUGS-77456: Add dynamic NodePort range validation

[jparrill]

Summary

Manual backport of #7652

• Add validation for NodePort.Port to ensure ports fall within the cluster's configured ServiceNodePortRange
• Reads cluster-specific ServiceNodePortRange or uses default (30000-32767)
• Allows port 0 (dynamic assignment) and provides clear error messages with the actual configured range
• Prevents late failures during cluster provisioning when the control-plane-operator rejects ports outside the acceptable range

Test plan

• Unit tests for TestParseNodePortRange pass
• Unit tests for TestValidateNodePortPortRange pass
• Verify validation rejects ports outside configured range
• Verify validation allows port 0 for dynamic assignment

🤖 Generated with Claude Code

[openshift-ci-robot]

@jparrill: This pull request references Jira Issue OCPBUGS-77456, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Manual backport of #7652

• Add validation for NodePort.Port to ensure ports fall within the cluster's configured ServiceNodePortRange
• Reads cluster-specific ServiceNodePortRange or uses default (30000-32767)
• Allows port 0 (dynamic assignment) and provides clear error messages with the actual configured range
• Prevents late failures during cluster provisioning when the control-plane-operator rejects ports outside the acceptable range

Test plan

• Unit tests for TestParseNodePortRange pass
• Unit tests for TestValidateNodePortPortRange pass
• Verify validation rejects ports outside configured range
• Verify validation allows port 0 for dynamic assignment

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[jparrill]

/jira refresh

[openshift-ci-robot]

@jparrill: This pull request references Jira Issue OCPBUGS-77456, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.z) matches configured target version for branch (4.21.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-65824 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-65824 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (yli2@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[bryan-cox]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, jparrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [bryan-cox,jparrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jparrill]

/verified by e2e

[openshift-ci-robot]

@jparrill: This PR has been marked as verified by e2e.

Details

In response to this:

/verified by e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[csrwng]

/label backport-risk-assessed

[jparrill]

/retest-required

[jparrill]

/retest-required

[jparrill]

/retest-required

[openshift-ci]

@jparrill: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@jparrill: Jira Issue Verification Checks: Jira Issue OCPBUGS-77456
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-77456 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Summary

Manual backport of #7652

• Add validation for NodePort.Port to ensure ports fall within the cluster's configured ServiceNodePortRange
• Reads cluster-specific ServiceNodePortRange or uses default (30000-32767)
• Allows port 0 (dynamic assignment) and provides clear error messages with the actual configured range
• Prevents late failures during cluster provisioning when the control-plane-operator rejects ports outside the acceptable range

Test plan

• Unit tests for TestParseNodePortRange pass
• Unit tests for TestValidateNodePortPortRange pass
• Verify validation rejects ports outside configured range
• Verify validation allows port 0 for dynamic assignment

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-robot]

Fix included in accepted release 4.21.0-0.nightly-2026-03-16-041356