HIVE-3002: IBMCloud MachinePools: Snowflake FailureDomain matching

[2uasimojo]

We've been using cluster-control-plane-machineset-operator (CPMS) utilities to extract failure domains from MachineSets for comparison when matching up generated msets with remote ones. CPMS doesn't support IBMCloud, so we were quietly getting back a generic (empty) failure domain for all IBMCloud msets, resulting in false positive matches and bad controller behavior (namely deleting all but one of the remote MachineSets).

Here we add local code to interpret the Zone from the providerSpec as the failure domain and match on it.

[openshift-ci-robot]

@2uasimojo: This pull request references HIVE-3002 which is a valid jira issue.

Details

In response to this:

We've been using cluster-control-plane-machineset-operator (CPMS) utilities to extract failure domains from MachineSets for comparison when matching up generated msets with remote ones. CPMS doesn't support IBMCloud, so we were quietly getting back a generic (empty) failure domain for all IBMCloud msets, resulting in false positive matches and bad controller behavior (namely deleting all but one of the remote MachineSets).

Here we add local code to interpret the Zone from the providerSpec as the failure domain and match on it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[2uasimojo]

/hold for QE

[codecov]

Codecov Report

❌ Patch coverage is 46.15385% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.70%. Comparing base (26db049) to head (3f207cb).
⚠️ Report is 18 commits behind head on master.

Files with missing lines	Patch %	Lines
...g/controller/machinepool/machinepool_controller.go	46.15%	3 Missing and 4 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2825      +/-   ##
==========================================
+ Coverage   50.40%   50.70%   +0.30%     
==========================================
  Files         279      279              
  Lines       34194    34534     +340     
==========================================
+ Hits        17236    17511     +275     
- Misses      15597    15642      +45     
- Partials     1361     1381      +20     

Files with missing lines	Coverage Δ
...g/controller/machinepool/machinepool_controller.go	67.00% <46.15%> (+3.77%)	⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[huangmingxia]

/test konflux

[openshift-ci]

@huangmingxia: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test coverage

/test e2e

/test e2e-azure

/test e2e-gcp

/test e2e-openstack

/test e2e-pool

/test e2e-vsphere

/test images

/test periodic-images

/test security

/test unit

/test verify

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-hive-master-coverage

pull-ci-openshift-hive-master-e2e

pull-ci-openshift-hive-master-e2e-pool

pull-ci-openshift-hive-master-images

pull-ci-openshift-hive-master-periodic-images

pull-ci-openshift-hive-master-security

pull-ci-openshift-hive-master-unit

pull-ci-openshift-hive-master-verify

Details

In response to this:

/test konflux

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[huangmingxia]

/retest

[red-hat-konflux]

Caution

There are some errors in your PipelineRun template.

PipelineRun	Error
hive-mce-210-on-pull-request	CEL expression evaluation error: expression "event == \"pull_request\"\n&& !body.pull_request.draft\n&& target_branch == \"master\"\n&& !files.all.all(x, x.matches('^docs/|\\\\.md$|^(?:.*/)?(?:\\\\.gitignore|OWNERS|PROJECT|LICENSE)$'))\n" failed to evaluate: no such key: pull_request
hive-mce-211-on-pull-request	CEL expression evaluation error: expression "event == \"pull_request\"\n&& !body.pull_request.draft\n&& target_branch == \"master\"\n&& !files.all.all(x, x.matches('^docs/|\\\\.md$|^(?:.*/)?(?:\\\\.gitignore|OWNERS|PROJECT|LICENSE)$'))\n" failed to evaluate: no such key: pull_request
hive-mce-26-on-pull-request	CEL expression evaluation error: expression "event == \"pull_request\"\n&& !body.pull_request.draft\n&& target_branch == \"master\"\n&& !files.all.all(x, x.matches('^docs/|\\\\.md$|^(?:.*/)?(?:\\\\.gitignore|OWNERS|PROJECT|LICENSE)$'))\n" failed to evaluate: no such key: pull_request
hive-mce-27-on-pull-request	CEL expression evaluation error: expression "event == \"pull_request\"\n&& !body.pull_request.draft\n&& target_branch == \"master\"\n&& !files.all.all(x, x.matches('^docs/|\\\\.md$|^(?:.*/)?(?:\\\\.gitignore|OWNERS|PROJECT|LICENSE)$'))\n" failed to evaluate: no such key: pull_request
hive-mce-28-on-pull-request	CEL expression evaluation error: expression "event == \"pull_request\"\n&& !body.pull_request.draft\n&& target_branch == \"master\"\n&& !files.all.all(x, x.matches('^docs/|\\\\.md$|^(?:.*/)?(?:\\\\.gitignore|OWNERS|PROJECT|LICENSE)$'))\n" failed to evaluate: no such key: pull_request
hive-mce-29-on-pull-request	CEL expression evaluation error: expression "event == \"pull_request\"\n&& !body.pull_request.draft\n&& target_branch == \"master\"\n&& !files.all.all(x, x.matches('^docs/|\\\\.md$|^(?:.*/)?(?:\\\\.gitignore|OWNERS|PROJECT|LICENSE)$'))\n" failed to evaluate: no such key: pull_request
hive-on-pull-request	CEL expression evaluation error: expression "event == \"pull_request\"\n&& !body.pull_request.draft\n&& target_branch == \"master\"\n&& !files.all.all(x, x.matches('^docs/|\\\\.md$|^(?:.*/)?(?:\\\\.gitignore|OWNERS|PROJECT|LICENSE)$'))\n" failed to evaluate: no such key: pull_request

[2uasimojo]

/test security

[2uasimojo]

/retest hive-mce-28

[openshift-ci-robot]

@2uasimojo: This pull request references HIVE-3002 which is a valid jira issue.

Details

In response to this:

We've been using cluster-control-plane-machineset-operator (CPMS) utilities to extract failure domains from MachineSets for comparison when matching up generated msets with remote ones. CPMS doesn't support IBMCloud, so we were quietly getting back a generic (empty) failure domain for all IBMCloud msets, resulting in false positive matches and bad controller behavior (namely deleting all but one of the remote MachineSets).

Here we add local code to interpret the Zone from the providerSpec as the failure domain and match on it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[2uasimojo]

/test e2e

[2uasimojo]

/test hive-mce-26-on-pull-request

[2uasimojo]

/test verify
/override "Red Hat Konflux"
/assign @dlom
/hold cancel

[openshift-ci]

@2uasimojo: Overrode contexts on behalf of 2uasimojo: Red Hat Konflux

Details

In response to this:

/test verify
/override "Red Hat Konflux"
/assign @dlom
/hold cancel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[dlom]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, dlom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [2uasimojo,dlom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[2uasimojo]

/override "Red Hat Konflux"

?

[openshift-ci]

@2uasimojo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.