FXP pkg update to support dual port configuration

[arunvelayutham]

No description provided.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arunvelayutham
Once this PR has been reviewed and has the lgtm label, please assign vrindle for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @arunvelayutham. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[thom311]

@arunvelayutham hi. Could you please improve the commit messages involved?

For example, "HACK - revert back to dual port support on IPU"

• Why? Why did you do this now? What is the overall goal? Is there a issue or mailing list discussion to link to?
• "revert" indicates to go back to some previously working state. To where? What was working previously (dual port support?) and what is currently broken (by what)?
• "HACK" indicates that there is a problem with this approach. What is the problem? Will this require some future fixes? Which future fixes will it require? If not, why do you call this a hack?
• I guess, you are importing a certain git commit here. Which exact code (git commit SHA) did you import? Did you run a script or command to do that? If yes, which command so that the commit can be re-produced? If you did it manually, how did you do it? As this is likely a generated commit, it would be useful to explain how you generated it.

Please explain such things in the commit message. These things are not obvious and we shouldn't leave non-experts (like myself) puzzled about what happens. Thank you!!

It should not be long, but the WHY is important. And if you use words like "revert" or "HACK", then you need to explain what is reverted (from where to what) and why this is a HACK (and why doing that instead of something else). If you think this is not worth explaining, then better avoid such loaded words that immediately pose questions. Then it's not a "hack", but just the regular change and nothing to comment about.

[bn222]

/ok-to-test

[openshift-ci]

@arunvelayutham: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/make-vendor-check	00f89e9	link	true	/test make-vendor-check
ci/prow/make-e2e-test	00f89e9	link	true	/test make-e2e-test
ci/prow/verify-deps	00f89e9	link	true	/test verify-deps

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.