Move Intel vsp-p4 plugin yaml context one level above

[arunvelayutham]

Move Intel vsp-p4 plugin yaml context one level above

[openshift-ci]

Hi @arunvelayutham. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[wizhaoredhat]

/ok-to-test

[thom311]

the commit takes the files from vendor/github.com/intel/ipu-opi-plugins/ipu-plugin/pkg/infrapod/bindata/vsp-p4-pvc.

For one, the commit message should explain where exactly those files come from. Also, it is not clear why this is done, why it is necessary or why it is a good idea.

Also, the commit renames the files. I understand you try to renumber them, but is that really necessary? Even if you end up with two files starting with 01., does it actually hurt? As the files are literally identical as from the vendored directory, can we keep the filenames unchanged?

[arunvelayutham]

@thom311 just getting back on this PR. This PR is a follow-up to #569 where @bn222 refactored the dpu-operator to handle vsp-plugin cleanup sequence as desired (vsp-p4 to wait for vsp-plugin to finish pod cleanup procedure where it explicitly deletes the P4 rules).

lexical (or numeric) ordering of P4 yaml failnames are required to maintain the bring-up and delete sequence of pods.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arunvelayutham
Once this PR has been reviewed and has the lgtm label, please assign vrindle for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@arunvelayutham: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/make-test	859f618	link	true	/test make-test
ci/prow/make-e2e-test	859f618	link	true	/test make-e2e-test
ci/prow/make-e2e-test-marvell	859f618	link	true	/test make-e2e-test-marvell

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[bn222]

Consider mount directly from the host, we can assume that the user puts it in a certain path.