Marvell VSP: Add configurable MAC learning for OVS data plane

[alkama-hasan]

Added isMacLearning parameter to control bridge switching behavior. When true, configures highest priority NORMAL flow for MAC-based learning. When false, allows traffic routing through network functions.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alkama-hasan
Once this PR has been reviewed and has the lgtm label, please assign vrindle for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @alkama-hasan. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[thom311]

please rebase the PR to latest main branch.

Also, let's see how the tests work with SKIP_NF_TESTING removed to see how all tests would pass.

[alkama-hasan]

please rebase the PR to latest main branch.

Done.

let's see how the tests work with SKIP_NF_TESTING removed to see how all tests would pass.

By default it will run a full test-suite? if yes we can definetly try or do you think any changes in e2e-test is needed ?

[thom311]

By default it will run a full test-suite? if yes we can definetly try or do you think any changes in e2e-test is needed ?

If we remove all occurrances of the skipNetworkFunctionTesting variable, then the tests will run.

In the best case, the test then just passes and we are good. If the test then fails, we will need to investigate (and maybe fix later, that test failure does not have to block this PR).

In step 1, let's see how all the tests would work.

[alkama-hasan]

In step 1, let's see how all the tests would work.

@thom311 can you write ok to test then

[thom311]

@thom311 can you write ok to test then

You didn't yet add a commit to drop skipNetworkFunctionTesting. So the most interesting tests will be skipped.
Anyway.

/ok-to-test

[alkama-hasan]

@thom311

You didn't yet add a commit to drop skipNetworkFunctionTesting. So the most interesting tests will be skipped.
Anyway.

as i see all the test passed. i just wanted to know what is the difference between
make-e2e-test
and make-e2e-test-marvell?

[thom311]

i just wanted to know what is the difference between make-e2e-test and make-e2e-test-marvell?

ci/prow/make-e2e-test run task e2e-test in Jenkins on a system that has an Intel IPU.
ci/prow/make-e2e-test-marvell runs task e2e-test on a system with a Marvell DPU.

[bn222]

/hold (note to self, don't merge until skipNetworkFunctionTesting is removed).

[alkama-hasan]

skipNetworkFunctionTesting is removed

@thom311 @bn222
Is the plan here to remove the feature skipNetworkFunctionTesting itself?
and do you want me to have a patch for this as part of this PR?

[bn222]

Remove the if test that disables running that test in this pr. That will test the mac learning indirectly as well.

[thom311]

@alkama-hasan in CI, we see that one test still fails: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_dpu-operator/562/pull-ci-openshift-dpu-operator-main-make-e2e-test-marvell/1970413889745063936

I think that is because the code sets EXTERNAL_CLIENT_DEV=eno12409, but on the host where the test runs, this interface is called eno2.

Could you confirm that by pushing a test patch that changes EXTERNAL_CLIENT_DEV=eno2?

--

If that is the problem, then the error message on the test failure should be improved (to be more clear). But also, we probably should then fix that with

    EXTERNAL_CLIENT_DEV="${EXTERNAL_CLIENT_DEV:-eno12409}"

and then the Jenkins configuration would export that environment.

[bn222]

Instead of moving things into jenkins again, we should determine that external interface dynamically or we should move the CI to 2 workers with a Marvell DPU in each.

[thom311]

let's do #579.

And, set EXTERNAL_CLIENT_DEV=eno2 in Jenkins, for the Marvell job.

[openshift-ci]

@alkama-hasan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/make-e2e-test-marvell	afe4a3b	link	true	/test make-e2e-test-marvell

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[thom311]

/test make-e2e-test

[thom311]

I took the first patch of this PR and re-submitted it (unmodified, but rebased) as #611.

The problems with (lack of) CI must not block a valid patch.