IIC-763 Ignore iputils when installing nmcli as it is a weak dep

[saynb]

No description provided.

[openshift-ci]

Hi @saynb. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[saynb]

@thom311 @bn222 What is exactly the further ask here? I have tested this change locally. Do you want to make permanent change to incremental build logic for this? If there is nothing else to do, can we please get an ok-to-test?

[bn222]

as of now, CI doesn't rebuild the changes that you're proposing here, so it's not testing the changes. We need to hash the dockerfile in it's entirety and then don't do an incremental build in case the hash changes. https://github.com/openshift/dpu-operator/blob/main/taskfiles/images.yaml#L26-L45

[saynb]

We need to hash the dockerfile in it's entirety and then don't do an incremental build in case the hash changes.

@bn222 I added an extra line in the dockerfile to force a rebuild. It worked locally for me so hopefully it will work here too. The solution that you are asking for here, that seems like keeping and maintaining computed hash of the dockerfile locally? Is that common practice? Seems like an involved change. How does the incremental vs full build get differentiated today?

[saynb]

Can someone please give an ok-to-test on this so that we can see if it is being triggered ?

[swtaylor]

/ok-to-test

[bn222]

@thom311 @bn222 What is exactly the further ask here? I have tested this change locally. Do you want to make permanent change to incremental build logic for this? If there is nothing else to do, can we please get an ok-to-test?

please fix the incremental build logic. It doesn't rebuild if you make a change to the dockerfile.

[saynb]

How does the incremental vs full build get differentiated today?

What about this?

[bn222]

First build is complete, any new build is incremental regardless of what the dockerfile contains.
We lack differentiation based on file contents. That's what's missing.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: saynb
Once this PR has been reviewed and has the lgtm label, please assign thom311 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bn222]

/retest

[openshift-ci]

@saynb: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/make-e2e-test	580b239	link	true	/test make-e2e-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-merge-robot]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale