Skip to content

helm: Fall back gracefully when chart URL has no matching repository #16049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sowmya-sl wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −1
Open

helm: Fall back gracefully when chart URL has no matching repository #16049

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pkg/helm/actions/utility.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,10 @@ func getChartInfoFromChartUrl(
}
}
}
return nil, fmt.Errorf("could not find a repository for the chart url %q in namespace %q", chartUrl, namespace)
klog.Infof("Could not find a repository for the chart url %q in namespace %q, proceeding without repository authentication", chartUrl, namespace)
return &ChartInfo{
Version: chartVersionFromURL(chartUrl),
}, nil
Comment on lines +133 to +135
Copy link

@webbnh webbnh Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, we fabricate a Version from the URL but we leave the Name blank? That seems like a curious choice...can't we extract the Name from the URL too? Is there a reason why we don't want to do that? (And, are we prepared for what happens if we return empty-handed from chartVersionFromURL()? In particular, is this going to do the right thing given an oci:// URL?)

Copy link
Contributor Author

@sowmya-sl sowmya-sl Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other fields are tied to repository - repository.Name, repository.Namespace, chartIndex. This is for a case where there is no repository available. We don't want to guess these names, as the customer might have input them differently.

}

// getRepositoryConnectionConfig returns the connection configuration for the
Expand Down