CONSOLE-5093: Remove support for deprecated extensions#16043
CONSOLE-5093: Remove support for deprecated extensions#16043logonoff wants to merge 4 commits intoopenshift:mainfrom
Conversation
|
@logonoff: This pull request references CONSOLE-5093 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
df2bb55 to
ce3ab44
Compare
|
@logonoff: This pull request references CONSOLE-5093 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: logonoff The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
📝 WalkthroughWalkthroughThis pull request removes support for two deprecated extension types: 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
|
@logonoff: This pull request references CONSOLE-5093 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@frontend/packages/console-dynamic-plugin-sdk/release-notes/4.22.md`:
- Around line 23-24: Fix the grammar in the sentence about the deprecated
extension: update the sentence referencing `console.page/resource/tab` and
`console.tab/horizontalNav` so it reads "deprecated in favor of
`console.tab/horizontalNav` extension" (i.e., insert the missing word "of"
before `console.tab/horizontalNav`).
frontend/packages/console-dynamic-plugin-sdk/release-notes/4.22.md
Outdated
Show resolved
Hide resolved
2c4f88d to
ed156c7
Compare
Update 4.22.md
we already have a demo of CustomOverviewDetailItem so we don't need two of them
ed156c7 to
e140c2f
Compare
frontend/packages/console-dynamic-plugin-sdk/release-notes/4.22.md
Outdated
Show resolved
Hide resolved
e140c2f to
94f15aa
Compare
|
@logonoff: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
console.page/resource/tab(deprecated in 4.11) - useconsole.tab/horizontalNavinsteadconsole.dashboards/overview/detail/item(deprecated in 4.12) - useconsole.dashboards/custom/overview/detail/iteminsteadSummary by CodeRabbit
Breaking Changes
console.page/resource/tabextension type; migrate toconsole.tab/horizontalNavconsole.dashboards/overview/detail/itemextension type; migrate toconsole.dashboards/custom/overview/detail/itemDocumentation