OCPBUGS-74557: Fixed Metrics page React error #306 by exporting QueryBrowser component by krishagarwal278 · Pull Request #16016 · openshift/console

krishagarwal278 · 2026-02-10T18:59:08Z

After:

Summary by CodeRabbit

New Features
- Query browser component is now available in the public API for developers to use.

…ing QueryBrowser component

openshift-ci-robot · 2026-02-10T18:59:15Z

@krishagarwal278: This pull request references Jira Issue OCPBUGS-74557, which is invalid:

expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

After:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-02-10T19:00:22Z

📝 Walkthrough

Walkthrough

This pull request expands the public API surface of the console-shared components package by re-exporting the query-browser module through the main components index file. The change adds a single export statement (export * from './query-browser') to frontend/packages/console-shared/src/components/index.ts, making query-browser components and utilities available to consumers of the package without requiring direct path imports.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title references exporting QueryBrowser component to fix a React error, which directly aligns with the changeset that adds a public re-export of './query-browser' from the components index file.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

logonoff

what components are importing from console shared root barrel that require this? can we rewrite the imports instead of writing an export?

krishagarwal278 · 2026-02-10T19:32:52Z

/jira refresh

openshift-ci-robot · 2026-02-10T19:33:00Z

@krishagarwal278: This pull request references Jira Issue OCPBUGS-74557, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

krishagarwal278 · 2026-02-10T19:33:32Z

/retest

krishagarwal278 · 2026-02-13T15:14:48Z

/retest

krishagarwal278 · 2026-02-16T16:41:46Z

Hi @logonoff i now changed the imports in MonitoringDashboardGraph and resource-metrics to use console/dynamic-plugin-sdk/src/lib-core instead of direct path imports from console/shared avoiding the barrel export. Metrics page loading as expected 👍🏻

krishagarwal278 · 2026-02-16T16:45:55Z

/acknowledge-critical-fixes-only

logonoff

/lgtm

krishagarwal278 · 2026-02-16T18:04:14Z

/retest

logonoff · 2026-02-16T19:02:45Z

ERROR in HandleCyclesPlugin: 5 total cycles detected, 0 of which are min-length :-(

You'll need to fix some cycles

krishagarwal278 · 2026-02-17T13:49:30Z

/retest

logonoff

If it works it works..

/lgtm

openshift-ci · 2026-02-17T15:40:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krishagarwal278, logonoff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [logonoff]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

krishagarwal278 · 2026-02-17T15:46:29Z

/label acknowledge-critical-fixes-only

krishagarwal278 · 2026-02-17T16:05:51Z

/verified later @yanpzhan

openshift-ci-robot · 2026-02-17T16:06:06Z

@krishagarwal278: This PR has been marked to be verified later by @yanpzhan.

Details

In response to this:

/verified later @yanpzhan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

logonoff

/hold

now that I think about it.. there's another file frontend/public/components/utils/resource-metrics.tsx which also imports from @console/shared/src/components/query-browser... do we need to update that?

Does updating the import directly to use

import { QueryBrowser } from '@console/shared/src/components/query-browser/QueryBrowser';

work..?

krishagarwal278 · 2026-02-17T19:31:40Z

i mean that import is working fine in resource-metrics.tsx

what i mean is, the metrics page here isn't crashing and rendering as expected

i updated my import from the original console/shared to avoid the cycles issue

logonoff · 2026-02-17T20:01:47Z

okay that's fair.. I suppose we can try the other way in a follow up. not a big problem but I find it a little weird importing from dynamic-core-api.ts since it's meant as a re-export file for plugins

/unhold

krishagarwal278 · 2026-02-17T21:20:38Z

/retest

krishagarwal278 · 2026-02-18T03:09:16Z

/retest

openshift-ci · 2026-02-18T12:30:36Z

@krishagarwal278: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2026-02-18T12:30:37Z

@krishagarwal278: Jira Issue OCPBUGS-74557: All pull requests linked via external trackers have merged:

openshift/console#16016

This pull request has the verified-later tag and will need to be manually moved to VERIFIED after testing. Jira Issue OCPBUGS-74557 has been moved to the MODIFIED state.

Details

In response to this:

After:
Summary by CodeRabbit

New Features

Query browser component is now available in the public API for developers to use.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jhadvig · 2026-02-18T13:11:38Z

/cherry-pick release-4.21

openshift-cherrypick-robot · 2026-02-18T13:12:24Z

@jhadvig: new pull request created: #16038

Details

In response to this:

/cherry-pick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

krishagarwal278 · 2026-02-18T13:57:00Z

/cherrypick release-4.19

krishagarwal278 · 2026-02-18T13:57:35Z

/cherry-pick release-4.19

openshift-cherrypick-robot · 2026-02-18T13:57:42Z

@krishagarwal278: #16016 failed to apply on top of branch "release-4.19":

Applying: OCPBUGS-74557: Fixed Metrics page React error #306 by exporting QueryBrowser component
Using index info to reconstruct a base tree...
M	frontend/packages/console-shared/src/components/index.ts
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/console-shared/src/components/index.ts
CONFLICT (content): Merge conflict in frontend/packages/console-shared/src/components/index.ts
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 OCPBUGS-74557: Fixed Metrics page React error #306 by exporting QueryBrowser component

Details

In response to this:

/cherrypick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2026-02-18T13:58:23Z

@krishagarwal278: #16016 failed to apply on top of branch "release-4.19":

Applying: OCPBUGS-74557: Fixed Metrics page React error #306 by exporting QueryBrowser component
Using index info to reconstruct a base tree...
M	frontend/packages/console-shared/src/components/index.ts
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/console-shared/src/components/index.ts
CONFLICT (content): Merge conflict in frontend/packages/console-shared/src/components/index.ts
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 OCPBUGS-74557: Fixed Metrics page React error #306 by exporting QueryBrowser component

Details

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

krishagarwal278 · 2026-02-18T14:31:05Z

/cherry-pick release-4.20

openshift-cherrypick-robot · 2026-02-18T14:31:50Z

@krishagarwal278: new pull request created: #16040

Details

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

OCPBUGS-74557: Fixed Metrics page React error openshift#306 by export…

de39aa8

…ing QueryBrowser component

openshift-ci bot requested review from Leo6Leo and sg00dwin February 10, 2026 19:00

openshift-ci bot added the component/shared Related to console-shared label Feb 10, 2026

logonoff reviewed Feb 10, 2026

View reviewed changes

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 10, 2026

openshift-ci bot requested a review from yapei February 10, 2026 19:33

Use SDK import path for QueryBrowser component

30b93e3

openshift-ci bot added component/core Related to console core functionality component/dev-console Related to dev-console labels Feb 16, 2026

logonoff approved these changes Feb 16, 2026

View reviewed changes

openshift-ci bot assigned logonoff Feb 16, 2026

openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 16, 2026

Fixed import cycles error

962fec2

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2026

logonoff approved these changes Feb 17, 2026

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2026

openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Feb 17, 2026

openshift-ci-robot added verified-later verified Signifies that the PR passed pre-merge verification criteria labels Feb 17, 2026

logonoff reviewed Feb 17, 2026

View reviewed changes

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2026

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2026

openshift-merge-bot bot merged commit 55e73cc into openshift:main Feb 18, 2026
8 checks passed

openshift-cherrypick-robot mentioned this pull request Feb 18, 2026

[release-4.21] OCPBUGS-77029: Fixed Metrics page React error #306 by exporting QueryBrowser component #16038

Open

openshift-cherrypick-robot mentioned this pull request Feb 18, 2026

[release-4.20] OCPBUGS-77037: Fixed Metrics page React error #306 by exporting QueryBrowser component #16040

Open

Comments

Conversation

krishagarwal278 commented Feb 10, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

openshift-ci-robot commented Feb 10, 2026

Uh oh!

coderabbitai bot commented Feb 10, 2026

Walkthrough

Uh oh!

logonoff left a comment

Choose a reason for hiding this comment

Uh oh!

krishagarwal278 commented Feb 10, 2026

Uh oh!

openshift-ci-robot commented Feb 10, 2026

Uh oh!

krishagarwal278 commented Feb 10, 2026

Uh oh!

krishagarwal278 commented Feb 13, 2026

Uh oh!

krishagarwal278 commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

krishagarwal278 commented Feb 16, 2026

Uh oh!

logonoff left a comment

Choose a reason for hiding this comment

Uh oh!

krishagarwal278 commented Feb 16, 2026

Uh oh!

logonoff commented Feb 16, 2026

Uh oh!

krishagarwal278 commented Feb 17, 2026

Uh oh!

logonoff left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Feb 17, 2026

Uh oh!

krishagarwal278 commented Feb 17, 2026

Uh oh!

krishagarwal278 commented Feb 17, 2026

Uh oh!

openshift-ci-robot commented Feb 17, 2026

Uh oh!

logonoff left a comment

Choose a reason for hiding this comment

Uh oh!

krishagarwal278 commented Feb 17, 2026

Uh oh!

logonoff commented Feb 17, 2026

Uh oh!

krishagarwal278 commented Feb 17, 2026

Uh oh!

krishagarwal278 commented Feb 18, 2026

Uh oh!

Uh oh!

openshift-ci bot commented Feb 18, 2026

Uh oh!

openshift-ci-robot commented Feb 18, 2026

Summary by CodeRabbit

Uh oh!

jhadvig commented Feb 18, 2026

Uh oh!

openshift-cherrypick-robot commented Feb 18, 2026

Uh oh!

krishagarwal278 commented Feb 18, 2026

Uh oh!

krishagarwal278 commented Feb 18, 2026

Uh oh!

openshift-cherrypick-robot commented Feb 18, 2026

Uh oh!

openshift-cherrypick-robot commented Feb 18, 2026

Uh oh!

krishagarwal278 commented Feb 18, 2026

Uh oh!

openshift-cherrypick-robot commented Feb 18, 2026

Uh oh!

krishagarwal278 commented Feb 10, 2026 •

edited by coderabbitai bot

Loading

krishagarwal278 commented Feb 16, 2026 •

edited

Loading