OCPBUGS-60426: Fix edit application via Deploy image internal registry doesn't select correct image stream

[vikram-raj]

Before:

before-edit-application.mov

After:

after-edit-application.mov

[openshift-ci-robot]

@vikram-raj: This pull request references Jira Issue OCPBUGS-60426, which is invalid:

• expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Before:

before-edit-application.mov

After:

after-edit-application.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

Adds a new constant RUNTIME_ICON_LABEL = 'app.openshift.io/runtime-icon' and updates label handling across components and tests to prefer this new label when deriving runtime icon values, with fallback to the existing runtime label and prior fallbacks preserved.

Changes

Cohort / File(s)	Change Summary
Constants frontend/packages/dev-console/src/const.ts	Adds exported constant RUNTIME_ICON_LABEL = 'app.openshift.io/runtime-icon'.
Edit application frontend/packages/dev-console/src/components/edit-application/edit-application-utils.ts, frontend/packages/dev-console/src/components/edit-application/__tests__/edit-application-data.ts	Import RUNTIME_ICON_LABEL; include the label in getDefaultLabels; prefer RUNTIME_ICON_LABEL when deriving runtimeIcon (fallback to RUNTIME_LABEL); test fixture updated to include the new label.
Import submission frontend/packages/dev-console/src/components/import/import-submit-utils.ts	Import and prefer RUNTIME_ICON_LABEL when deriving runtimeIcon from ImageStream metadata labels, falling back to RUNTIME_LABEL.
Resource label utilities & topology frontend/packages/dev-console/src/utils/resource-label-utils.ts, frontend/packages/topology/src/data-transforms/transform-utils.ts	Use RUNTIME_ICON_LABEL when constructing or reading resource labels and when resolving builder image icon; preserve existing fallback order and other fallbacks.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Verify RUNTIME_ICON_LABEL is exported correctly from const.ts and all imports updated.
• Confirm consistent fallback order: RUNTIME_ICON_LABEL → RUNTIME_LABEL → other fallbacks.
• Run/inspect updated unit test fixture in __tests__/edit-application-data.ts to ensure expectations match new label usage.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[vikram-raj]

/jira refresh

[openshift-ci-robot]

@vikram-raj: This pull request references Jira Issue OCPBUGS-60426, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[vikram-raj]

/cc @logonoff

[logonoff]

doesn't this mean we won't display any icons that were set prior to this bugfix?

[vikram-raj]

No, we will display the icon that were set prior to this.

[logonoff]

/lgtm

[vikram-raj]

/verified later @yapei

[openshift-ci-robot]

@vikram-raj: This PR has been marked to be verified later by @yapei.

Details

In response to this:

/verified later @yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[vikram-raj]

/verified later @yapei

[vikram-raj]

/retest

[logonoff]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS [logonoff,vikram-raj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 335ed77 and 2 for PR HEAD 139d1df in total

[openshift-bot]

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

[openshift-ci-robot]

@openshift-bot: This pull request references Jira Issue OCPBUGS-60426, which is invalid:

• expected the bug to target either version "4.22." or "openshift-4.22.", but it targets "4.21.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[vikram-raj]

/jira refresh

[openshift-ci-robot]

@vikram-raj: This pull request references Jira Issue OCPBUGS-60426, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 336f9f8 and 1 for PR HEAD 139d1df in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 4b8da82 and 0 for PR HEAD 139d1df in total

[openshift-ci-robot]

/hold

Revision 139d1df was retested 3 times: holding

[vikram-raj]

/unhold

/retest

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 19b01f0 and 2 for PR HEAD 139d1df in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 9ac9e36 and 1 for PR HEAD 139d1df in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD d3b540a and 0 for PR HEAD 139d1df in total

[openshift-ci]

@vikram-raj: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@vikram-raj: Jira Issue OCPBUGS-60426: All pull requests linked via external trackers have merged:

• openshift/console#15795

This pull request has the verified-later tag and will need to be manually moved to VERIFIED after testing. Jira Issue OCPBUGS-60426 has been moved to the MODIFIED state.

Details

In response to this:

Before:

before-edit-application.mov

After:

after-edit-application.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-robot]

Fix included in accepted release 4.22.0-0.nightly-2025-12-21-224908

[vikram-raj]

/cherry-pick release-4.21

[openshift-cherrypick-robot]

@vikram-raj: new pull request created: #15879

Details

In response to this:

/cherry-pick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.