CNF-23047: Migrate away from deprecated ioutil

[sebrandon1]

ioutil has been deprecated since Go 1.16: https://go.dev/doc/go1.16#ioutil

Tracking issue: redhat-best-practices-for-k8s/telco-bot#52

Summary by CodeRabbit

• Chores
  • Modernized internal file-reading and cleaned up imports to remove deprecated usage; no behavioral changes or public API impact.
• Tests
  • Updated end-to-end metrics test to use current reading APIs and refreshed imports so tests align with the modernized code.

[openshift-ci-robot]

@sebrandon1: This pull request explicitly references no jira issue.

Details

In response to this:

ioutil has been deprecated since Go 1.16: https://go.dev/doc/go1.16#ioutil

Tracking issue: redhat-best-practices-for-k8s/telco-bot#52

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jhadvig]

/lgtm
/approve

[jhadvig]

/override ci/prow/e2e-gcp-ovn

[openshift-ci]

@jhadvig: Overrode contexts on behalf of jhadvig: ci/prow/e2e-gcp-ovn

Details

In response to this:

/override ci/prow/e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[sebrandon1]

/retest

[jhadvig]

/retest

[jhadvig]

/verified by CI
/lgtm

[openshift-ci-robot]

@jhadvig: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, sebrandon1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jhadvig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD b9608d2 and 2 for PR HEAD 334e8b8 in total

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD 4bd76c3 and 1 for PR HEAD 334e8b8 in total

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD f061939 and 0 for PR HEAD 334e8b8 in total

[openshift-merge-bot]

/hold

Revision 334e8b8 was retested 3 times: holding

[openshift-bot]

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

[openshift-ci-robot]

@openshift-bot: This pull request explicitly references no jira issue.

Retaining the jira/valid-bug label as it was manually added.

Details

In response to this:

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[sebrandon1]

/retest

[openshift-ci-robot]

@sebrandon1: This pull request references CNF-23047 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Retaining the jira/valid-bug label as it was manually added.

Details

In response to this:

ioutil has been deprecated since Go 1.16: https://go.dev/doc/go1.16#ioutil

Tracking issue: redhat-best-practices-for-k8s/telco-bot#52

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

New changes are detected. LGTM label has been removed.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: b82dcf7b-54f0-414c-b0f5-b8cf5ce9b6e5

📥 Commits

Reviewing files that changed from the base of the PR and between 4b964f3 and 3a506f3.

📒 Files selected for processing (2)

• test/e2e/metrics_test.go
• tools/import-verifier/import-verifier.go

✅ Files skipped from review due to trivial changes (1)

• tools/import-verifier/import-verifier.go

🚧 Files skipped from review as they are similar to previous changes (1)

• test/e2e/metrics_test.go

---

Walkthrough

The code replaces deprecated ioutil calls with modern equivalents: tests use io.ReadAll; the import verifier uses os.ReadFile and drops the unused io/ioutil import. No control flow or public APIs changed.

Changes

I/O modernization

Layer / File(s)	Summary
Metrics test: use io.ReadAll test/e2e/metrics_test.go	Added io import and replaced ioutil.ReadAll(resp.Body) with io.ReadAll(resp.Body) in the metrics E2E test.
Import verifier: use os.ReadFile tools/import-verifier/import-verifier.go	Removed io/ioutil import and replaced ioutil.ReadFile(configFile) with os.ReadFile(configFile) in loadImportRestrictions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 13 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is minimal and does not follow the required template structure with sections like Analysis/Root cause, Solution description, Test setup, Test cases, Browser conformance, etc.	Expand the description to follow the repository template: add Analysis/Root cause, detailed Solution description, Test setup, Test cases, and other required sections.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (13 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: migrating away from the deprecated ioutil package.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The check for stable and deterministic Ginkgo test names is not applicable. The PR changes files using standard Go testing framework (testing.T), not Ginkgo framework.
Test Structure And Quality	✅ Passed	The PR contains no Ginkgo tests. Both modified files use standard Go testing, not Ginkgo's BDD framework. The check is not applicable to this refactoring PR.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added. PR only modernizes deprecated ioutil calls to standard library equivalents without changing test logic or adding new tests.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new Ginkgo e2e tests are added. Changes only migrate deprecated ioutil functions to modern equivalents (os.ReadFile, io.ReadAll) in existing code.
Topology-Aware Scheduling Compatibility	✅ Passed	PR replaces deprecated Go ioutil functions in a utility tool and test file; contains no deployment manifests, scheduling constraints, or topology-related code.
Ote Binary Stdout Contract	✅ Passed	PR migrates deprecated ioutil functions to modern alternatives (os.ReadFile, io.ReadAll) with no stdout behavior changes. Not applicable as repository is not an OTE binary extension.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new Ginkgo e2e tests added. PR only refactors existing code by replacing deprecated ioutil APIs with non-deprecated equivalents, which does not affect IPv6/network compatibility.
No-Weak-Crypto	✅ Passed	PR migrates from deprecated ioutil to standard Go packages (os.ReadFile, io.ReadAll). No weak crypto patterns detected.
Container-Privileges	✅ Passed	PR only modifies Go source files updating deprecated ioutil to modern stdlib; no container/K8s manifests with privileged security settings present.
No-Sensitive-Data-In-Logs	✅ Passed	PR migrates from deprecated ioutil to modern stdlib functions. No new logging introduced; existing logs only contain error messages and status codes, not sensitive data.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sebrandon1]

/unhold

[sebrandon1]

/retest

[sebrandon1]

/retest

[openshift-ci]

@sebrandon1: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-ovn	3a506f3	link	true	/test e2e-gcp-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.