Skip to content

OSASINFRA-3675: Add credentialRequest for manila namespace #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 2 commits into from
Jun 2, 2025
Merged

OSASINFRA-3675: Add credentialRequest for manila namespace #573

openshift-merge-bot merged 2 commits into from
Jun 2, 2025

Conversation

@dkokkino
Copy link

@dkokkino dkokkino commented Apr 1, 2025

  • Required to generate manila-cloud-credentials secret in the manila namespace used for authentication

Add credentialRequest for manila namespace
83116dc 
 - Required to generate manila-cloud-credentials in the manila namespace
   used for authentication
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 1, 2025 •
edited by openshift-ci bot
Loading

@dkokkino: This pull request references OSASINFRA-3675 which is a valid jira issue.

Details

In response to this:

  • Required to generate manila-cloud-credentials secret in the manila namespace used for authentication

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 1, 2025
@openshift-ci openshift-ci bot requested review from dobsonj and gnufied April 1, 2025 15:40
@gnufied
Copy link
Member

gnufied commented Apr 1, 2025

/assign @EmilienM @stephenfin

@dkokkino
Copy link
Author

dkokkino commented Apr 2, 2025

/retest

2 similar comments
@dkokkino
Copy link
Author

dkokkino commented Apr 3, 2025

/retest

@dkokkino
Copy link
Author

dkokkino commented Apr 7, 2025

/retest

@stephenfin stephenfin mentioned this pull request Apr 14, 2025
Open
1 task
@stephenfin
Copy link
Contributor

stephenfin commented Apr 14, 2025

/lgtm

I also need this for openshift/csi-operator#359

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2025
@jsafrane
Copy link
Contributor

jsafrane commented Apr 14, 2025

/test e2e-openstack-manila-csi

@stephenfin
Copy link
Contributor

stephenfin commented Apr 15, 2025

/retest-required

Test timed out. Looks like a overloaded environment. Let's re-run things.

@jsafrane
Copy link
Contributor

jsafrane commented Apr 15, 2025

/retest
manila is not required ;-)

@jsafrane
Copy link
Contributor

jsafrane commented Apr 15, 2025

Anyway, the cluster installation succeeded + the CSI driver looks working (many tests succeeded), the new credentials request did not break it.
/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2025
@stephenfin
Copy link
Contributor

stephenfin commented Apr 15, 2025

/retest manila is not required ;-)

Oh, indeed. Whoops! 😄

@stephenfin
Copy link
Contributor

stephenfin commented Apr 16, 2025

/test e2e-openstack-manila-csi

@stephenfin
Copy link
Contributor

stephenfin commented Apr 16, 2025

/test e2e-openstack-manila-csi

Lack of quota on the environment. That cloud is rather unstable 🙈

@mandre
Copy link
Member

mandre commented Apr 22, 2025

/test e2e-openstack-manila-csi

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2025
@dkokkino
Copy link
Author

dkokkino commented May 7, 2025

/retest

@stephenfin
Copy link
Contributor

stephenfin commented May 14, 2025

/test e2e-openstack-manila-csi

Tests are timing out. I also see : [bz-etcd][invariant] alert/etcdMemberCommunicationSlow should not be at or above info firing though, so I'm guessing this is just a slow node.

@stephenfin
Copy link
Contributor

stephenfin commented May 14, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2025
@gnufied
Copy link
Member

gnufied commented May 20, 2025

So we request credentials regardless of the fact whether openstack install supports manilla or not?

@stephenfin
Copy link
Contributor

stephenfin commented May 21, 2025 •
edited
Loading

So we request credentials regardless of the fact whether openstack install supports manilla or not?

Yes. This is what we are already doing for all other CSI drivers:

❯ git rev-parse HEAD
d8e992082c4413cbdc5b4ee4d8b4f6962b45af9b  # main as of time of comment
❯ ls manifests/03_credentials_request_* -1
manifests/03_credentials_request_aws.yaml
manifests/03_credentials_request_azure_file.yaml
manifests/03_credentials_request_azure.yaml
manifests/03_credentials_request_cinder.yaml
manifests/03_credentials_request_gcp.yaml
manifests/03_credentials_request_ibm.yaml
manifests/03_credentials_request_manila.yaml
manifests/03_credentials_request_ovirt.yaml
manifests/03_credentials_request_powervs.yaml
manifests/03_credentials_request_vsphere_csi.yaml
manifests/03_credentials_request_vsphere_detector.yaml

Unless I'm missing something?

@gnufied
Copy link
Member

gnufied commented May 21, 2025

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkokkino, gnufied, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@duanwei33
Copy link

duanwei33 commented May 30, 2025

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label May 30, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 30, 2025 •
edited by openshift-ci bot
Loading

@dkokkino: This pull request references OSASINFRA-3675 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.20." or "openshift-4.20.", but it targets "openshift-4.19" instead.

Details

In response to this:

  • Required to generate manila-cloud-credentials secret in the manila namespace used for authentication

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 30, 2025

/retest-required

Remaining retests: 0 against base HEAD 424839c and 2 for PR HEAD 52a99fb in total

1 similar comment
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 2, 2025

/retest-required

Remaining retests: 0 against base HEAD 424839c and 2 for PR HEAD 52a99fb in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2025 •
edited
Loading

@dkokkino: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud-csi 52a99fb link false /test e2e-ibmcloud-csi
ci/prow/okd-scos-e2e-aws-ovn 52a99fb link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-openstack-manila-csi 52a99fb link false /test e2e-openstack-manila-csi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 2, 2025

/retest-required

Remaining retests: 0 against base HEAD 424839c and 2 for PR HEAD 52a99fb in total

@openshift-merge-bot openshift-merge-bot bot merged commit 9772438 into openshift:main Jun 2, 2025
19 of 22 checks passed
@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 2, 2025

[ART PR BUILD NOTIFIER]

Distgit: cluster-storage-operator
This PR has been included in build ose-cluster-storage-operator-container-v4.20.0-202506021713.p0.g9772438.assembly.stream.el9.
All builds following this will include this PR.

@stephenfin stephenfin deleted the OSASINFRA-3675 branch June 12, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dobsonj dobsonj Awaiting requested review from dobsonj

@gnufied gnufied Awaiting requested review from gnufied

Assignees

@gnufied gnufied

@EmilienM EmilienM

@stephenfin stephenfin

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@dkokkino @openshift-ci-robot @gnufied @stephenfin @jsafrane @mandre @duanwei33 @openshift-bot @EmilienM