Periodic sync of supported OCP samples#695
Open
aroyoredhat wants to merge 1 commit into
Open
Conversation
WalkthroughReplace blank image values in Rails/PostgreSQL deployment templates and update Node.js/PHP ImageStream tag sets across multiple architecture-specific OpenShift manifests. ChangesContainer Image Template Variables
ImageStream Tag Updates
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (11 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aroyoredhat The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
aroyoredhat
force-pushed
the
periodic-ocp-sync
branch
from
e4a284d to
7a9f263
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@assets/operator/ocp-aarch64/php/imagestreams/php-rhel-aarch64.json`:
- Around line 166-176: Verify that the backing image referenced by the PHP 8.4
(Latest) imagestream is actually available and pullable: check
registry.redhat.io for registry.redhat.io/ubi10/php-84:latest and attempt a
docker/podman pull (using Red Hat credentials if required); if the image is
missing or not accessible, update the imagestream "from.name" value (currently
"8.4-ubi10") to a valid ImageStreamTag or explicit image reference that exists,
or add a note in the imagestream metadata documenting that Red Hat registry
credentials are required and provide the correct pullspec to avoid deployment
failures.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 61022e20-2acf-4d92-b17b-3e93898b2550
📒 Files selected for processing (12)
assets/operator/ocp-aarch64/nodejs/imagestreams/nodejs-rhel-aarch64.jsonassets/operator/ocp-aarch64/php/imagestreams/php-rhel-aarch64.jsonassets/operator/ocp-aarch64/rails/templates/rails-pgsql-persistent.jsonassets/operator/ocp-ppc64le/nodejs/imagestreams/nodejs-rhel.jsonassets/operator/ocp-ppc64le/php/imagestreams/php-rhel.jsonassets/operator/ocp-ppc64le/rails/templates/rails-pgsql-persistent.jsonassets/operator/ocp-s390x/nodejs/imagestreams/nodejs-rhel.jsonassets/operator/ocp-s390x/php/imagestreams/php-rhel.jsonassets/operator/ocp-s390x/rails/templates/rails-pgsql-persistent.jsonassets/operator/ocp-x86_64/nodejs/imagestreams/nodejs-rhel.jsonassets/operator/ocp-x86_64/php/imagestreams/php-rhel.jsonassets/operator/ocp-x86_64/rails/templates/rails-pgsql-persistent.json
💤 Files with no reviewable changes (4)
- assets/operator/ocp-ppc64le/nodejs/imagestreams/nodejs-rhel.json
- assets/operator/ocp-s390x/nodejs/imagestreams/nodejs-rhel.json
- assets/operator/ocp-x86_64/nodejs/imagestreams/nodejs-rhel.json
- assets/operator/ocp-aarch64/nodejs/imagestreams/nodejs-rhel-aarch64.json
Comment on lines
+166
to
+176
| "description": "Build and run PHP 8.4 applications on UBI 10. For more information about using this builder image, including OpenShift considerations, see https://github.com/sclorg/s2i-php-container/blob/master/8.4/README.md.\n\nWARNING: By selecting this tag, your application will automatically update to use the latest version available on OpenShift, including major version updates.\n", | ||
| "iconClass": "icon-php", | ||
| "openshift.io/display-name": "PHP 8.3 (Latest)", | ||
| "openshift.io/display-name": "PHP 8.4 (Latest)", | ||
| "openshift.io/provider-display-name": "Red Hat, Inc.", | ||
| "sampleRepo": "https://github.com/sclorg/cakephp-ex.git", | ||
| "tags": "builder,php", | ||
| "version": "8.3" | ||
| "version": "8.4" | ||
| }, | ||
| "from": { | ||
| "kind": "ImageStreamTag", | ||
| "name": "8.3-ubi10" | ||
| "name": "8.4-ubi10" |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify PHP 8.4 UBI10 image is pullable and documentation exists
# Check if the PHP 8.4 documentation exists
curl -s -o /dev/null -w "%{http_code}" https://github.com/sclorg/s2i-php-container/blob/master/8.4/README.md
# Note: Image registry verification would require authentication to registry.redhat.io
echo "Manual verification needed: Confirm registry.redhat.io/ubi10/php-84:latest is available in Red Hat registry"Repository: openshift/cluster-samples-operator
Length of output: 189
Confirm PHP 8.4 “Latest” docs and manually verify backing image availability
In assets/operator/ocp-aarch64/php/imagestreams/php-rhel-aarch64.json, the PHP 8.4 (Latest) stream points to 8.4-ubi10; the linked s2i-php-container 8.4 README URL is reachable (HTTP 200). Still confirm that registry.redhat.io/ubi10/php-84:latest exists and is pullable (may require Red Hat registry credentials) to prevent deployment failures.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@assets/operator/ocp-aarch64/php/imagestreams/php-rhel-aarch64.json` around
lines 166 - 176, Verify that the backing image referenced by the PHP 8.4
(Latest) imagestream is actually available and pullable: check
registry.redhat.io for registry.redhat.io/ubi10/php-84:latest and attempt a
docker/podman pull (using Red Hat credentials if required); if the image is
missing or not accessible, update the imagestream "from.name" value (currently
"8.4-ubi10") to a valid ImageStreamTag or explicit image reference that exists,
or add a note in the imagestream metadata documenting that Red Hat registry
credentials are required and provide the correct pullspec to avoid deployment
failures.
Contributor
Author
|
/retest-required |
Contributor
|
@aroyoredhat: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncing the latest supported OCP samples from the library.
Created using https://github.com/aroyoredhat/trigger-test-samples-build
Summary by CodeRabbit
Bug Fixes
New Features
Deprecations