CNTRLPLANE-2241: Update library-go to get KMS encryption#837
CNTRLPLANE-2241: Update library-go to get KMS encryption#837openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
No actionable comments were generated in the recent review. 🎉 WalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
added
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@go.mod`:
- Around line 134-137: The go.mod replace directive temporarily points
github.com/openshift/library-go to a personal fork
(github.com/ardaguclu/library-go); remove that replace entry (or change it to
the official module/version) so the project depends on the upstream
github.com/openshift/library-go instead of the personal fork, ensuring the
replace block no longer references github.com/ardaguclu/library-go.
go.mod
Outdated
| replace ( | ||
| github.com/onsi/ginkgo/v2 => github.com/openshift/onsi-ginkgo/v2 v2.6.1-0.20251001123353-fd5b1fb35db1 | ||
| github.com/openshift/library-go => github.com/ardaguclu/library-go v0.0.0-20260210063250-9351ccf4cb16 | ||
| ) |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# First, let's check the repository context and understand the go.mod file
pwd
git ls-files go.mod | head -20Repository: openshift/cluster-authentication-operator
Length of output: 110
🏁 Script executed:
# Check the full go.mod file to understand the context
head -150 go.mod | tail -50Repository: openshift/cluster-authentication-operator
Length of output: 2590
🏁 Script executed:
# Look for any PR metadata or documentation files
git ls-files | grep -E "(DESCRIPTION|PR|NOTES|TODO|README)" | head -20Repository: openshift/cluster-authentication-operator
Length of output: 955
🏁 Script executed:
# Search for any comments or TODOs mentioning library-go or kms
rg -i "library-go|kms" --type md --type txt -A 2 -B 2Repository: openshift/cluster-authentication-operator
Length of output: 15965
🏁 Script executed:
# Check git log for this specific change
git log --all --oneline --grep="library-go" -i | head -10
git log --all --oneline --grep="kms" -i | head -10Repository: openshift/cluster-authentication-operator
Length of output: 1138
🏁 Script executed:
# Check if there are any CI/CD configuration files that might indicate test-only status
git ls-files | grep -E "(\.github|\.gitlab|\.circleci|Makefile|\.mk)" | head -20Repository: openshift/cluster-authentication-operator
Length of output: 1099
🏁 Script executed:
# Check current branch and which branches contain this commit
git rev-parse --abbrev-ref HEAD
git branch -a --contains 8fa97618
# Check the most recent commit on main/master
git log main --oneline -1 2>/dev/null || git log master --oneline -1
# Check if the replace directive change is in the current default branch
git show main:go.mod 2>/dev/null | grep -A 5 "^replace" || git show master:go.mod 2>/dev/null | grep -A 5 "^replace"Repository: openshift/cluster-authentication-operator
Length of output: 289
🏁 Script executed:
# Check the status of the working directory to see if go.mod has uncommitted changes
git status go.mod
# Show the current go.mod replace directive
git show HEAD:go.mod | grep -A 5 "^replace"Repository: openshift/cluster-authentication-operator
Length of output: 368
🏁 Script executed:
# Look for any PR or issue context that might indicate this is temporary
# Check for any TODO, FIXME, or comments about reverting this change
rg -i "TODO|FIXME|revert|temporary|temp" go.mod -B 3 -A 3
git log --all --grep="revert\|temporary\|temp" -i --oneline | grep -i library-goRepository: openshift/cluster-authentication-operator
Length of output: 67
Remove personal fork replacement before merging to production.
The replace directive points github.com/openshift/library-go to a personal fork (github.com/ardaguclu/library-go). While the commit message confirms this is for testing KMS functionality, this must be reverted before merging to the master branch, as personal forks introduce security risks (potential supply chain vulnerabilities) and maintainability issues (forks may diverge from the official library). Ensure the original github.com/openshift/library-go is restored in the final version.
🤖 Prompt for AI Agents
In `@go.mod` around lines 134 - 137, The go.mod replace directive temporarily
points github.com/openshift/library-go to a personal fork
(github.com/ardaguclu/library-go); remove that replace entry (or change it to
the official module/version) so the project depends on the upstream
github.com/openshift/library-go instead of the personal fork, ensuring the
replace block no longer references github.com/ardaguclu/library-go.
|
/test e2e-gcp-operator-encryption |
|
/retest |
1 similar comment
|
/retest |
ardaguclu
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@ardaguclu: This pull request references CNTRLPLANE-2241 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@ardaguclu: This pull request references CNTRLPLANE-2241 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm /hold let's wait for the encryption (optional) CI jobs. |
openshift-ci
bot
added
the
do-not-merge/hold
|
/assign @liouk for approval |
|
/retest-required |
|
@ardaguclu: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
This can be considered a safe change because imported changes can only be used by enabling |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
|
/verified by e2e-gcp-operator-encryption-kms ci |
openshift-ci-robot
added
the
verified
|
@ardaguclu: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ardaguclu, liouk, p0lyn0mial The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 4cdf558
into
openshift:master
5 participants
This PR is to update library-go to get openshift/library-go#2086