Skip to content

Add aws-eusc-qe cluster profile#4973

Open
liweinan wants to merge 1 commit intoopenshift:mainfrom
liweinan:add-aws-eusc-qe-profile
Open

Add aws-eusc-qe cluster profile#4973
liweinan wants to merge 1 commit intoopenshift:mainfrom
liweinan:add-aws-eusc-qe-profile

Conversation

@liweinan
Copy link

@liweinan liweinan commented Feb 27, 2026

This commit adds support for the AWS European Sovereign Cloud (EUSC) cluster profile for QE testing. The profile targets the eusc-de-east-1 region in AWS EUSC partition.

Changes:

  • Add ClusterProfileAWSEUSCQE constant ("aws-eusc-qe")
  • Add profile to ClusterProfiles() list
  • Add profile to ClusterType() aws case
  • Add LeaseType() mapping to "aws-eusc-qe"

Region Details:

  • Region: eusc-de-east-1 (Brandenburg, Germany)
  • Partition: aws-eusc
  • Availability zones: eusc-de-east-1a, eusc-de-east-1b

Dependencies:

EUSC Service Endpoints (for reference):

Summary by CodeRabbit

  • New Features
    • Added support for a new AWS EU South Central cluster profile ("aws-eusc-qe") with corresponding lease type mappings and cloud type classification.

This commit adds support for the AWS European Sovereign Cloud (EUSC)
cluster profile for QE testing. The profile targets the eusc-de-east-1
region in AWS EUSC partition.

Changes:
- Add ClusterProfileAWSEUSCQE constant ("aws-eusc-qe")
- Add profile to ClusterProfiles() list
- Add profile to ClusterType() aws case
- Add LeaseType() mapping to "aws-eusc-qe"

Region Details:
- Region: eusc-de-east-1 (Brandenburg, Germany)
- Partition: aws-eusc
- Availability zones: eusc-de-east-1a, eusc-de-east-1b

Dependencies:
- Release repo PR for boskos/secret configuration
- Installer support: openshift/installer#10303

EUSC Service Endpoints (for reference):
- EC2: https://ec2.eusc-de-east-1.amazonaws.eu
- ELB: https://elasticloadbalancing.eusc-de-east-1.amazonaws.eu
- S3: https://s3.eusc-de-east-1.amazonaws.eu
- Route53: https://route53.amazonaws.eu
- IAM: https://iam.eusc-de-east-1.amazonaws.eu
- STS: https://sts.eusc-de-east-1.amazonaws.eu
- Tagging: https://tagging.eusc-de-east-1.amazonaws.eu
@openshift-ci-robot
Copy link
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@coderabbitai
Copy link

coderabbitai bot commented Feb 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 27060f7 and 3913a61.

📒 Files selected for processing (1)
  • pkg/api/types.go

Walkthrough

A new AWS cluster profile variant, ClusterProfileAWSEUSCQE, is introduced with the identifier "aws-eusc-qe". The new profile is registered across type definitions, cluster classification mappings, and lease type resolution functions.

Changes

Cohort / File(s) Summary
Cluster Profile Extension
pkg/api/types.go
Added new ClusterProfile constant ClusterProfileAWSEUSCQE with value "aws-eusc-qe", and registered it in ClusterProfiles(), ClusterType(), LeaseType(), and LeaseTypeFromClusterType() functions with appropriate AWS and lease type mappings.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Add aws-eusc-qe cluster profile' clearly and concisely describes the main change: introducing a new cluster profile constant with related enum mappings.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Stable And Deterministic Test Names ✅ Passed This PR only modifies pkg/api/types.go to add a cluster profile constant and contains no test code changes.
Test Structure And Quality ✅ Passed PR only modifies constants and functions in pkg/api/types.go with no test code changes, making this test review check not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 27, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liweinan
Once this PR has been reviewed and has the lgtm label, please assign hector-vido for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 27, 2026

@liweinan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 3913a61 link true /test images
ci/prow/checkconfig 3913a61 link true /test checkconfig
ci/prow/breaking-changes 3913a61 link false /test breaking-changes

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants