Skip to content

DPTP-4340: Remove direct mirroring to registry.ci.openshift.org, consolidate to single promotion step #4866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deepsm007 wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −2
Open

DPTP-4340: Remove direct mirroring to registry.ci.openshift.org, consolidate to single promotion step #4866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f270d2
DPTP-4340: Remove direct mirroring to registry.ci.openshift.org, cons…
deepsm007 Dec 5, 2025
661cd2f
Fix unit test: update expected promotion steps after removing direct …
deepsm007 Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pkg/defaults/defaults.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,6 @@ func fromConfig(
return nil, nil, fmt.Errorf("cannot promote images, no promotion configuration defined")
}

promotionSteps = append(promotionSteps, releasesteps.PromotionStep(api.PromotionStepName, config, requiredNames, jobSpec, podClient, pushSecret, registryDomain(config.PromotionConfiguration), api.DefaultMirrorFunc, api.DefaultTargetNameFunc, nodeArchitectures))
// Used primarily (only?) by the ci-chat-bot
if config.PromotionConfiguration.RegistryOverride != "" {
logrus.Info("No images to promote to quay.io if the registry is overridden")
Expand Down
2 changes: 1 addition & 1 deletion pkg/defaults/defaults_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1733,7 +1733,7 @@ func TestFromConfig(t *testing.T) {
},
promote: true,
expectedSteps: []string{"[output-images]", "[images]"},
expectedPost: []string{"[promotion]", "[promotion-quay]"},
expectedPost: []string{"[promotion-quay]"},
}, {
name: "duplicate input images",
config: api.ReleaseBuildConfiguration{
Expand Down