Skip to content

ClusterAPI revision components can be empty #2728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Feb 27, 2026
+16 −15
Merged

ClusterAPI revision components can be empty #2728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions openapi/generated_openapi/zz_generated.openapi.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions operator/v1alpha1/types_clusterapi.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,12 +144,13 @@ type ClusterAPIInstallerRevision struct {
// +optional
UnmanagedCustomResourceDefinitions []string `json:"unmanagedCustomResourceDefinitions,omitempty"`

// components is list of components which will be installed by this
// revision. Components will be installed in the order they are listed.
// components is a list of components which will be installed by this
// revision. Components will be installed in the order they are listed. If
// omitted no components will be installed.
//
// The maximum number of components is 32.
//
// +required
// +optional
// +listType=atomic
// +kubebuilder:validation:MinItems=1
Copy link
Contributor

@JoelSpeed JoelSpeed Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put this back. We don't want an unstructured client to be able to set components: [] since a structured client cannot do this, it would create something that doesn't round trip.

// +kubebuilder:validation:MaxItems=32
Expand Down
6 changes: 3 additions & 3 deletions operator/v1alpha1/zz_generated.crd-manifests/0000_30_cluster-api_01_clusterapis.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,9 @@ spec:
properties:
components:
description: |-
components is list of components which will be installed by this
revision. Components will be installed in the order they are listed.
components is a list of components which will be installed by this
revision. Components will be installed in the order they are listed. If
omitted no components will be installed.

The maximum number of components is 32.
items:
Expand Down Expand Up @@ -224,7 +225,6 @@ spec:
type: array
x-kubernetes-list-type: atomic
required:
- components
- contentID
- name
- revision
Expand Down
6 changes: 3 additions & 3 deletions ...uregated-crd-manifests/clusterapis.operator.openshift.io/ClusterAPIMachineManagement.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,9 @@ spec:
properties:
components:
description: |-
components is list of components which will be installed by this
revision. Components will be installed in the order they are listed.
components is a list of components which will be installed by this
revision. Components will be installed in the order they are listed. If
omitted no components will be installed.

The maximum number of components is 32.
items:
Expand Down Expand Up @@ -225,7 +226,6 @@ spec:
type: array
x-kubernetes-list-type: atomic
required:
- components
- contentID
- name
- revision
Expand Down
2 changes: 1 addition & 1 deletion operator/v1alpha1/zz_generated.swagger_doc_generated.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions payload-manifests/crds/0000_30_cluster-api_01_clusterapis.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,9 @@ spec:
properties:
components:
description: |-
components is list of components which will be installed by this
revision. Components will be installed in the order they are listed.
components is a list of components which will be installed by this
revision. Components will be installed in the order they are listed. If
omitted no components will be installed.

The maximum number of components is 32.
items:
Expand Down Expand Up @@ -224,7 +225,6 @@ spec:
type: array
x-kubernetes-list-type: atomic
required:
- components
- contentID
- name
- revision
Expand Down